This repository has been archived by the owner on Apr 22, 2022. It is now read-only.
Add dockerfile and entrypoint script #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a Dockerfile and entrypoint script which should be good for production. The binary gets built in a build container separate from the resulting image.
Users can create a volume at /config to store the config.yml. The entrypoint script will check if the directory is empty when the container gets brought up, and if so, it will copy the config-example.yml into the /config/config.yml, which is the path that gets passed in as the config path.
If this is sufficient, it should solve #45
As @bmartel had mentioned, viper could be used to handle the config files, but that could probably be handled as a new issue