Fixes for ELPA support (v2) #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Please push anything that makes the ELPA situation better! |
This also checks if they exist. Which might even be a problem for `package-user-dir' on its own for a fresh GNU Emacs install. * methods/el-get-elpa.el (el-get-elpa-package-directory): Scan all package directories and make sure they exist.
This can happen if the package directory is simply deleted but it is still in the `package-list' and the user tries to re-install the package. It is an error but without the patch the error is caused in `file-relative-name'. * methods/el-get-elpa.el (el-get-elpa-symlink-package): Gracefully error if no directory is found.
In 24.4, simply removing the package directory is no longer enough. This will only set the package status to `deleted' but package.el will still think the package is installed and refuse a re-install. Calling `package-delete' will ensure the right thing is done. In 24.3 `package-delete' does only remove the directory so we stick with that, but loading dired is no longer necessary since emacs 23.2 when `delete-directory' got the optional RECURSIVE parameter. * methods/el-get-elpa.el (el-get-elpa-post-remove): Call `package-delete' to remove packages.
* methods/el-get-elpa.el (package-desc-summary, package-desc-version): make aliases to the new 24.4 names. (el-get-elpa-delete-package, el-get-elpa-descs): new wrapper functions to simulate 24.4 behaviour in 24.3 and below. (el-get-elpa-build-local-recipes, el-get-elpa-post-remove, el-get-elpa-update-available-p): use the new wrappers/aliases.
* methods/el-get-elpa.el (el-get-elpa-package-directory): use catch-throw instead of setting helper variable to achieve early loop exit.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends/replaces/ close #1756.
Basically follows #1756 (comment), with a bit of cleanup.