Check that a table still exists before running COPY. #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Postgres pg_dump, the situation of a DROP TABLE happening concurrently to the backup operation is prevented by taking an explicit ACCESS SHARE lock on all the tables early. This approach is limited to max_locks_per_transaction and can be problematic to operate given large schemas. In the context of pgcopydb though, we do not need to forbid DROP TABLE happening on the source server while the migration is running, we need to be able to skip a table that has been dropped before we get to COPY it.
dimitri
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Postgres pg_dump, the situation of a DROP TABLE happening concurrently to the backup operation is prevented by taking an explicit ACCESS SHARE lock on all the tables early.
This approach is limited to max_locks_per_transaction and can be problematic to operate given large schemas.
In the context of pgcopydb though, we do not need to forbid DROP TABLE happening on the source server while the migration is running, we need to be able to skip a table that has been dropped before we get to COPY it.