Initialize MSSQL library when used #1553
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The debian build doesn't seem to have or pull the new cl-mssql (doesn't find the new |
|
This build issue comes from the fact that this change requires the latest version of cl-mssql, more specifically, this specific PR. That PR was only merged yesterday. So I guess, it's expected since the CI job downloads the official cl-mssql version from the Debian repository. So I guess that unfortunately, it means we'd have to wait for cl-mssql to be updated there? |
|
Hi! I'm interested in getting this merged. From what I understand all that's missing is re-triggering the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes pgloader's behavior so that it properly initialize
freetds(throughcl-mssql) when working with a MS SQL Server database.This PR relies on the functions introduced in archimag/cl-mssql#11 (merged at the time of writing).
Before this PR, pgloader uses freetds directly without initialization. While the database copy does happen, users will see several instances of the following message:
This happens because the
freetdswas not initialized properly. This PR initializes the library when a SQL Server is used.Fixes #1354