Translate on different connection (#366)

* Able to translate on different connection

* Test setup for multiple connection

* Added test case

Added test case for translation on different connection

* Apply fixes from StyleCI #366

* Apply fixes from StyleCI #366

* Review changes

Added more assertions to make sure the record is not in default db connection

* Added check before set

* Apply fixes from StyleCI #366

Author: nsaumini

src/Translatable/Translatable.php

@@ -427,6 +427,10 @@ protected function saveTranslations()
         $saved = true;
         foreach ($this->translations as $translation) {
             if ($saved && $this->isTranslationDirty($translation)) {
+                if (! empty($connectionName = $this->getConnectionName())) {
+                    $translation->setConnection($connectionName);
+                }
+
                 $translation->setAttribute($this->getRelationKey(), $this->getKey());
                 $saved = $translation->save();
             }

tests/TestsBase.php

@@ -6,53 +6,65 @@
 class TestsBase extends TestCase
 {
     protected $queriesCount;
+    protected static $db2Setup = false;
 
     const DB_NAME = 'translatable_test';
+    const DB_NAME2 = 'translatable_test2';
     const DB_USERNAME = 'homestead';
     const DB_PASSWORD = 'secret';
 
     public function setUp()
     {
-        $this->makeSureDatabaseExists();
+        $this->makeSureDatabaseExists(static::DB_NAME);
+
+        if (! static::$db2Setup) {
+            $this->makeSureDatabaseExists(static::DB_NAME2);
+        }
 
         parent::setUp();
 
-        $this->makeSureSchemaIsCreated();
+        if (! static::$db2Setup) {
+            $this->makeSureSchemaIsCreated('mysql2');
+            $this->truncateAllTablesButMigrations(static::DB_NAME2);
+            static::$db2Setup = true;
+        }
+
+        $this->makeSureSchemaIsCreated('mysql');
         $this->enableQueryCounter();
         $this->refreshSeedData();
     }
 
     private function refreshSeedData()
     {
-        $this->truncateAllTablesButMigrations();
+        $this->truncateAllTablesButMigrations(static::DB_NAME);
         $seeder = new AddFreshSeeds;
         $seeder->run();
     }
 
-    private function makeSureDatabaseExists()
+    private function makeSureDatabaseExists($dbName)
     {
-        $this->runQuery('CREATE DATABASE IF NOT EXISTS '.static::DB_NAME);
+        $this->runQuery('CREATE DATABASE IF NOT EXISTS '.$dbName);
     }
 
-    private function makeSureSchemaIsCreated()
+    private function makeSureSchemaIsCreated($dbConnectionName)
     {
         $migrationsPath = '../../../../tests/migrations';
         $artisan = $this->app->make('Illuminate\Contracts\Console\Kernel');
 
         // Makes sure the migrations table is created
         $artisan->call('migrate', [
-            '--database' => 'mysql',
+            '--database' => $dbConnectionName,
             '--path'     => $migrationsPath,
         ]);
     }
 
-    private function truncateAllTablesButMigrations()
+    private function truncateAllTablesButMigrations($dbName)
     {
         $db = $this->app->make('db');
         $db->statement('SET FOREIGN_KEY_CHECKS=0;');
 
         foreach ($tables = $db->select('SHOW TABLES') as $table) {
-            $table = $table->{'Tables_in_'.static::DB_NAME};
+            $table = $table->{'Tables_in_'.$dbName};
             if ($table != 'migrations') {
                 $db->table($table)->truncate();
             }
@@ -101,6 +113,16 @@ protected function getEnvironmentSetUp($app)
             'collation' => 'utf8_unicode_ci',
             'strict' => false,
         ]);
+        $app['config']->set('database.connections.mysql2', [
+            'driver'   => 'mysql',
+            'host' => '127.0.0.1',
+            'database' => static::DB_NAME2,
+            'username' => static::DB_USERNAME,
+            'password' => static::DB_PASSWORD,
+            'charset' => 'utf8',
+            'collation' => 'utf8_unicode_ci',
+            'strict' => false,
+        ]);
         $app['config']->set('translatable.locales', ['el', 'en', 'fr', 'de', 'id']);
     }
 

tests/TranslatableTest.php

@@ -634,4 +634,32 @@ public function test_it_uses_fallback_locale_if_default_is_empty()
         $this->app->setLocale('fr');
         $this->assertEquals('Tunisia', $country->name);
     }
+
+    public function test_translation_with_multiconnection()
+    {
+        // Add country & translation in second db
+        $country = new Country();
+        $country->setConnection('mysql2');
+        $country->code = 'sg';
+        $country->{'name:sg'} = 'Singapore';
+        $this->assertTrue($country->save());
+
+        $countryId = $country->id;
+
+        // Verify added country & translation in second db
+        $country = new Country();
+        $country->setConnection('mysql2');
+        $sgCountry = $country->find($countryId);
+        $this->assertEquals('Singapore', $sgCountry->translate('sg')->name);
+
+        // Verify added country not in default db
+        $country = new Country();
+        $sgCountry = $country::where('code', 'sg')->get();
+        $this->assertEmpty($sgCountry);
+
+        // Verify added translation not in default db
+        $country = new Country();
+        $sgCountry = $country->find($countryId);
+        $this->assertEmpty($sgCountry->translate('sg'));
+    }
 }