kogs: Unrecoverable game tokens from lacking kogslamdata validation

[Alrighttt]

There is no validation on where the "turn baton" output must be sent to for kogsslamdata.

If a malicious party changes this CC address, it will make the deposited tokens of the game unrecoverable. While attempting to recover deposited tokens from a game like this, you will receive the following error:
CC Eval EVAL_KOGS Error!: invalid oper with game: could not add or remove tokens while game is running spending tx bdf0173c570c640c66e03d7c0c800beec9b5708bcbc7b9640d52fd66c1233f47

This leads to both the slammers and the containers being entirely unrecoverable.

To reproduce this, change kogsPk and/or destpk in the following line prior to doing kogsslamdata.

komodo/src/cc/kogs.cpp

Line 982 in 4272e90

mtx.vout.push_back(MakeCC1of2vout(EVAL_KOGS, KOGS_BATON_AMOUNT, kogsPk, destpk)); // baton to indicate whose turn is now, globalpk to allow autofinish stalled games

An example of this can be found on the MYKOG chain with gameid, 5951db41a86d096fbb27179b33259b6212e83cbb861515357b5f7ab764938f19. This txid:c70f9ab6fea922ac6c36a4d689f99b74acaa1912d3d805293d84e274722b8cc8 is the malformed kogsslamdata transaction.

[dimxy]

should validate the destpk is one of the player pks

[dimxy]

archived due to the closed project