[3.x] Laravel 7 Support #1715
Merged
[3.x] Laravel 7 Support #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
lloricode
approved these changes
Mar 9, 2020
|
Hi laravel/lumen 7 not install here, that why no error occurs.
|
lloricode
suggested changes
Mar 10, 2020
| @@ -13,24 +13,23 @@ | |||
| "email": "jason.lewis1991@gmail.com" | |||
| }], | |||
| "require": { | |||
| "php": "^7.1", | |||
| "dingo/blueprint": "^0.3", | |||
There was a problem hiding this comment.
This is not support in laravel 7
|
you can check installed laravel version on your local, before running test |
Closed
|
Good work on this I believe the blueprint package is needed for the docs generation, so we cannot drop that at this stage. Can you please put it back in, we will need to make it laravel 7 compatible also. Also fix conflicts. I created a new branch to work on laravel 7 compatibility, will get this merged into it. |
|
I tagged blueprint as v0.4.0 for laravel 7. |
added 2 commits
March 13, 2020 09:59
|
Great, thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potentially breaking update. With Laravel 7 there is new min requirements of PHP 7.2.5 (https://laravel.com/docs/7.x/upgrade#upgrade-7.0).
There is no way for dingo/api to work with PHP < 7 with implementing Throwable, not sure if that's an issue.
Note:
dingo/blueprinthas been removed as a core dependency. Ideally it wouldn't be a core package anymore and just exist as an optionally add-on. For now it can be re-added once there's a version with l7 support.