Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the new deprecated wagtail module routes #33

Closed
wants to merge 3 commits into from

Conversation

Tobi-De
Copy link

@Tobi-De Tobi-De commented Apr 17, 2023

This is an updated version of #28 with fixed linting issues

Thank you for contributing to Salesman, before you continue make sure that:

  • Tests still pass: poetry run pytest
  • There are no lint errors: poetry run pre-commit run --all-files

josueisaihs and others added 3 commits April 17, 2023 10:54
Change wagtail.admin.edit_handlers to wagtail.admin.panels

Change wagtail.core.urls to wagtail.urls
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #33 (4057c5a) into master (2e7d7e2) will decrease coverage by 0.11%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   99.94%   99.84%   -0.11%     
==========================================
  Files          50       50              
  Lines        1978     1984       +6     
==========================================
+ Hits         1977     1981       +4     
- Misses          1        3       +2     
Impacted Files Coverage Δ
salesman/admin/wagtail/mixins.py 97.72% <75.00%> (-2.28%) ⬇️
salesman/admin/wagtail_hooks.py 97.95% <75.00%> (-2.05%) ⬇️
salesman/admin/wagtail/panels.py 99.12% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Tobi-De
Copy link
Author

Tobi-De commented Apr 17, 2023

Hello @dinoperovic, could you please review and merge this pull request? Thank you.
I also have a question posted at #32

@dinoperovic
Copy link
Owner

@Tobi-De thanks! I will take a closer look soon.

@dinoperovic
Copy link
Owner

Hey @Tobi-De,

a new Salesman version 1.2.0 was released that drops support for older versions of Wagtail, which makes this PR obsolete.

Thank you for your effort 👍🏻

@dinoperovic dinoperovic closed this May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants