Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signed integer comparison is totally broken #1

Closed
dinuxbg opened this issue Nov 12, 2014 · 2 comments
Closed

Signed integer comparison is totally broken #1

dinuxbg opened this issue Nov 12, 2014 · 2 comments
Assignees
@dinuxbg
Labels
bug

Comments

@dinuxbg
Copy link
Owner

dinuxbg commented Nov 12, 2014

The cbranch pattern is totally broken for signed comparisons. First, we really support only equal length parameters. And second, the algorithm for turning signed into unsigned comparison is flawed.
@dinuxbg dinuxbg self-assigned this Nov 12, 2014
@dinuxbg dinuxbg added the bug label Nov 12, 2014
@dinuxbg
Copy link
Owner Author

dinuxbg commented Nov 12, 2014

Fix is being tested.

dinuxbg added a commit that referenced this issue Nov 15, 2014
@dinuxbg
PRU-GCC bugfix and initial version of a simulator
07a4882 
- Fix for a critical pru-gcc bug in signed comparison code generation (issue #1 in github).
- Add LOOP/ILOOP instructions to GAS.
- Initial version of PRU ISA simulator. There is no I/O support, so it will be useful mainly for verifying and testing pru-gcc.

Signed-off-by: Dimitar Dimitrov <dinuxbg@gmail.com>
@dinuxbg
Copy link
Owner Author

dinuxbg commented Nov 15, 2014

Fixed in 07a4882

@dinuxbg dinuxbg closed this as completed Nov 15, 2014
@dinuxbg dinuxbg mentioned this issue Sep 26, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dinuxbg dinuxbg

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dinuxbg