OLD-6412: Report - Most Downloaded files breaks report system

[cpaschen]

Description

After opening the 'Most Downloaded Files' report and sorting on the Downloads column (changing from descending to ascending), the entire Reports system in Tienda is not functioning.

Two errors are now displayed on the reports screen:

Warning: Invalid argument supplied for foreach() in .../administrator/components/com_tienda/models/reports.php on line 64

and

Warning: Invalid argument supplied for foreach() in /.../administrator/components/com_tienda/views/reports/tmpl/default.php on line 73

History

#4 Updated by Chris DioscouriChris Paschen. 6 months ago

And there isn't any data in the 'Downloads' column (that might be the thing that is causing the error in the first place).

#3 Updated by Chris DioscouriChris Paschen. 6 months ago

Affected Version changed from 0.8.2 to 0.8.2 / 0.9.1 r2545

FYI ... just doing some more testing and this is still an issue with 0.9.1 r2545

#2 Updated by Chris DioscouriChris Paschen. 8 months ago

Target version changed from Version 0.9.9 - Misc Bug Fixes and New Features to Version 0.9.4 - Plugin Testing and Finalization

#1 Updated by Chris DioscouriChris Paschen. 12 months ago

Logging out of the admin-side and then back in clears the errors.
(even without clearing the local cache)

NOTE: This only shows up after closing the report and being returned to the reports screen; however, even after going to other parts of Joomla the warning still appears until you log out of the admin site and back in.

Update Log time Watch Copy Delete

[efillman]

This report needs an overhaul, working on it.

[efillman]

Hey sorry for my tardiness, I am going to work on this tomorrow.

[rdiaztushman]

Nice!

Rafael Diaz-Tushman, President & CEO
Dioscouri Design: Form and Function
www.dioscouri.com
www.twitter.com/dioscouri
w. 917-830-7411

On Mon, Jan 7, 2013 at 5:50 PM, Evan Fillman notifications@github.comwrote:

Hey sorry for my tardiness, I am going to work on this tomorrow.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/79#issuecomment-11976101.

[efillman]

I need to phone a friend on this one guys. I have been tracing code for hours and think I have it narrowed down,

The question I have though that I need help with is that in this file
https://github.com/dioscouri/tienda/blob/master/tienda/admin/views/reports/tmpl/default.php#L5

state; ?> form; ?> items; ?>

Where are is this data coming from. I does not seem to be in the model? Sorry for the noobness.

[rdiaztushman]

Those are all set by the DSCView from the Library.
$this->state = $this->getModel()->getState();
$this->form = an array of values reused in forms
$this->items = $this->getModel()->getList()

R