Apply "in" to query even if array is empty #7816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the "in" array is empty we need to add it to query anyways, otherwise all records will be attached causing out of memory on subsequent calls
rijkvanzanten
approved these changes
Sep 3, 2021
TonyLovesDevOps
pushed a commit
to TonyLovesDevOps/directus
that referenced
this pull request
Sep 3, 2021
* fetch only avatar id for current user * apply "in" to query even if array is empty if the "in" array is empty we need to add it to query anyways, otherwise all records will be attached causing out of memory on subsequent calls
rijkvanzanten
added a commit
that referenced
this pull request
Sep 7, 2021
…assword hashes. (#7755) * 1. Create generatePasswordHash util function to standardize how user passwords are hashed throughout the API instead of directly calling argon2.hash directly; 2. Add configuration parameters to modify the behavior of the argon2.hash function used for generating user password hashes; 3. Add docs and placeholders in api/example.env for new parameters; 4. Update argon2 to latest release. * Also update CLI init command to call generatePasswordHash vs. calling argon2.hash directly. * docs: sdk auth.password.request url argument (#7757) * Show a warning if PostGIS is missing (#7759) * Show a warning if PostGIS is missing * Remove sqlite-extensions flag * Remove unused import * Update WYSIWYG styling * translations: fix user.status_invited (#7760) * New Crowdin updates (#7739) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Czech) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Russian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Czech) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * Fix postgis check * Fix branch emitter logic from grand-to-child (#7763) * New Crowdin updates (#7762) * New translations en-US.yaml (Russian) * New translations en-US.yaml (Slovenian) * New translations en-US.yaml (Chinese Simplified) * New translations en-US.yaml (French) * New translations en-US.yaml (Arabic) * New translations en-US.yaml (Catalan) * New translations en-US.yaml (German) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (German) * New translations en-US.yaml (Hungarian) * Fix tree-select not allowing groups to be opened in selection mode * Optimize tree-select open state * Warn the user when a collapsed group field had an error (#7738) * warn the user when a collapsed group field had an error * Replace icon * Reduce icon size Co-authored-by: rijkvanzanten <rijkvanzanten@me.com> * New translations en-US.yaml (Hungarian) (#7764) * fix WYSIWYG field focus event (#7756) * Update vue monorepo to v3.2.7 (#7766) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Fix hash link in docs module (#7768) * Update dependency knex-schema-inspector to v1.6.0 (#7769) * Use OpenMapTiles font instead of ArcGIS (#7780) * tiny rewrite in docs/reference/filter-rules (#7771) * Update dependency sass to v1.39.0 (#7770) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Expose logger through ExtensionContext (#7777) Fixes #7737. * Fixes bug when trying to edit geometry in code interface. (#7778) * Update vue monorepo to v3.2.8 (#7785) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Update dependency npm to v7.22.0 (#7786) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Improve card selection styling (#7787) * Add environment variable to force-exclude tables from Directus (#7789) * New Crowdin updates (#7765) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Polish) * v9.0.0-rc.92 * Update changelog.md * Update logging in CLI commands (#7676) * Replace console logs with logger in CLI commands * Fix double sparkles in migration command * Apply suggestions from code review Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com> * Use stdout for init command output Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com> * Fix WYSIWYG field not being cleared after "Save and Create New" (#7754) * fix WYSIWYG field not being cleared * return empty string when null for tinymce * Update app/src/components/v-form/form-field.vue Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com> * fix wrong icon (#7800) * fix false is proper value (#7796) * Fix incorrect database exclude tables environment variable in docs. (#7798) * Datetime interface "Set to now" sets seconds to 0 (#7794) When "Include seconds" is disabled. Fixes #7779 * Use https for openmaptiles fonts. (#7801) * fix type for deep query with underscore prefix (#7815) * Map selection behaviour (#7811) * Use https for openmaptiles fonts. * Changed map selection behaviour: replace instead of adding them by default. * Fix map interface controls not showing (#7812) * Fix return error for GraphQL mutations (#7814) * Apply "in" to query even if array is empty (#7816) * fetch only avatar id for current user * apply "in" to query even if array is empty if the "in" array is empty we need to add it to query anyways, otherwise all records will be attached causing out of memory on subsequent calls * Update dependency pinia to v2.0.0-rc.7 (#7817) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Update modules.md (#7795) * make csv imports try to parse values to json (#7820) * fix minor typo in api-hooks.md (#7821) * Update dependency knex to v0.95.11 (#7819) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Rename hash utils file/function to be not password-specific, update all calls to argon2.hash to use the new function, update docs. * 1. Create generatePasswordHash util function to standardize how user passwords are hashed throughout the API instead of directly calling argon2.hash directly; 2. Add configuration parameters to modify the behavior of the argon2.hash function used for generating user password hashes; 3. Add docs and placeholders in api/example.env for new parameters; 4. Update argon2 to latest release. * Also update CLI init command to call generatePasswordHash vs. calling argon2.hash directly. * Rename hash utils file/function to be not password-specific, update all calls to argon2.hash to use the new function, update docs. * Preserve old behavior of hash function in PayloadService, in case 'value' is not a String. * Tweak docs Co-authored-by: José Varela <joselcvarela@gmail.com> Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com> Co-authored-by: Ben Haynes <ben@directus.io> Co-authored-by: Nitwel <nitwel@arcor.de> Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Oreille <33065839+Oreilles@users.noreply.github.com> Co-authored-by: mikhail sergienko <mikhail.sergienko@gmail.com> Co-authored-by: Dieter Luypaert <dieterluypaert@gmail.com> Co-authored-by: Ben Haynes <ben@rngr.org> Co-authored-by: Sam Milledge <sam@sammilledge.com> Co-authored-by: ian <licitdev@gmail.com> Co-authored-by: Harun Kilic <harunkilic@live.dk>
AustinPhillipTaylor
pushed a commit
to AustinPhillipTaylor/directus
that referenced
this pull request
May 11, 2022
…assword hashes. (directus#7755) * 1. Create generatePasswordHash util function to standardize how user passwords are hashed throughout the API instead of directly calling argon2.hash directly; 2. Add configuration parameters to modify the behavior of the argon2.hash function used for generating user password hashes; 3. Add docs and placeholders in api/example.env for new parameters; 4. Update argon2 to latest release. * Also update CLI init command to call generatePasswordHash vs. calling argon2.hash directly. * docs: sdk auth.password.request url argument (directus#7757) * Show a warning if PostGIS is missing (directus#7759) * Show a warning if PostGIS is missing * Remove sqlite-extensions flag * Remove unused import * Update WYSIWYG styling * translations: fix user.status_invited (directus#7760) * New Crowdin updates (directus#7739) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Czech) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Russian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Czech) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * Fix postgis check * Fix branch emitter logic from grand-to-child (directus#7763) * New Crowdin updates (directus#7762) * New translations en-US.yaml (Russian) * New translations en-US.yaml (Slovenian) * New translations en-US.yaml (Chinese Simplified) * New translations en-US.yaml (French) * New translations en-US.yaml (Arabic) * New translations en-US.yaml (Catalan) * New translations en-US.yaml (German) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (German) * New translations en-US.yaml (Hungarian) * Fix tree-select not allowing groups to be opened in selection mode * Optimize tree-select open state * Warn the user when a collapsed group field had an error (directus#7738) * warn the user when a collapsed group field had an error * Replace icon * Reduce icon size Co-authored-by: rijkvanzanten <rijkvanzanten@me.com> * New translations en-US.yaml (Hungarian) (directus#7764) * fix WYSIWYG field focus event (directus#7756) * Update vue monorepo to v3.2.7 (directus#7766) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Fix hash link in docs module (directus#7768) * Update dependency knex-schema-inspector to v1.6.0 (directus#7769) * Use OpenMapTiles font instead of ArcGIS (directus#7780) * tiny rewrite in docs/reference/filter-rules (directus#7771) * Update dependency sass to v1.39.0 (directus#7770) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Expose logger through ExtensionContext (directus#7777) Fixes directus#7737. * Fixes bug when trying to edit geometry in code interface. (directus#7778) * Update vue monorepo to v3.2.8 (directus#7785) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Update dependency npm to v7.22.0 (directus#7786) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Improve card selection styling (directus#7787) * Add environment variable to force-exclude tables from Directus (directus#7789) * New Crowdin updates (directus#7765) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Polish) * v9.0.0-rc.92 * Update changelog.md * Update logging in CLI commands (directus#7676) * Replace console logs with logger in CLI commands * Fix double sparkles in migration command * Apply suggestions from code review Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com> * Use stdout for init command output Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com> * Fix WYSIWYG field not being cleared after "Save and Create New" (directus#7754) * fix WYSIWYG field not being cleared * return empty string when null for tinymce * Update app/src/components/v-form/form-field.vue Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com> * fix wrong icon (directus#7800) * fix false is proper value (directus#7796) * Fix incorrect database exclude tables environment variable in docs. (directus#7798) * Datetime interface "Set to now" sets seconds to 0 (directus#7794) When "Include seconds" is disabled. Fixes directus#7779 * Use https for openmaptiles fonts. (directus#7801) * fix type for deep query with underscore prefix (directus#7815) * Map selection behaviour (directus#7811) * Use https for openmaptiles fonts. * Changed map selection behaviour: replace instead of adding them by default. * Fix map interface controls not showing (directus#7812) * Fix return error for GraphQL mutations (directus#7814) * Apply "in" to query even if array is empty (directus#7816) * fetch only avatar id for current user * apply "in" to query even if array is empty if the "in" array is empty we need to add it to query anyways, otherwise all records will be attached causing out of memory on subsequent calls * Update dependency pinia to v2.0.0-rc.7 (directus#7817) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Update modules.md (directus#7795) * make csv imports try to parse values to json (directus#7820) * fix minor typo in api-hooks.md (directus#7821) * Update dependency knex to v0.95.11 (directus#7819) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Rename hash utils file/function to be not password-specific, update all calls to argon2.hash to use the new function, update docs. * 1. Create generatePasswordHash util function to standardize how user passwords are hashed throughout the API instead of directly calling argon2.hash directly; 2. Add configuration parameters to modify the behavior of the argon2.hash function used for generating user password hashes; 3. Add docs and placeholders in api/example.env for new parameters; 4. Update argon2 to latest release. * Also update CLI init command to call generatePasswordHash vs. calling argon2.hash directly. * Rename hash utils file/function to be not password-specific, update all calls to argon2.hash to use the new function, update docs. * Preserve old behavior of hash function in PayloadService, in case 'value' is not a String. * Tweak docs Co-authored-by: José Varela <joselcvarela@gmail.com> Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com> Co-authored-by: Ben Haynes <ben@directus.io> Co-authored-by: Nitwel <nitwel@arcor.de> Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Oreille <33065839+Oreilles@users.noreply.github.com> Co-authored-by: mikhail sergienko <mikhail.sergienko@gmail.com> Co-authored-by: Dieter Luypaert <dieterluypaert@gmail.com> Co-authored-by: Ben Haynes <ben@rngr.org> Co-authored-by: Sam Milledge <sam@sammilledge.com> Co-authored-by: ian <licitdev@gmail.com> Co-authored-by: Harun Kilic <harunkilic@live.dk>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7783
Also, request only id from
avatarfor the current user in the app