Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Check for full permissions before building the query #434

Closed
wellingguzman opened this issue Sep 26, 2018 · 3 comments
Closed

Check for full permissions before building the query #434

wellingguzman opened this issue Sep 26, 2018 · 3 comments

Comments

@wellingguzman
Copy link
Contributor

Some permissions need to consider while building the query, but we should ask for permissions upfront before working with the query. the user at least should have permission on read, any kind of permission.

@stale
Copy link

stale bot commented Dec 30, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 30, 2018
@benhaynes
Copy link
Member

Is this an enhancement? Is it still valid? @wellingguzman

@stale stale bot removed the stale label Jan 1, 2019
@wellingguzman
Copy link
Contributor Author

I think I opened this to remember or finished what was implement here probably: 68408d3.

I can't recall, but the point described in this ticket was implemented long time ago.

This issue: #627, is what next to fix in terms of permissions and ownership.

I will close this, unless there's something else related to this issue.

samvasko pushed a commit to samvasko/api that referenced this issue Nov 25, 2019
* Fetch more items on scrolling

* Add lazy loading state + spinner

* Add accent shadow on scroll
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants