Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Password in Logs #555

Closed
benhaynes opened this issue Nov 1, 2018 · 1 comment
Closed

Password in Logs #555

benhaynes opened this issue Nov 1, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@benhaynes
Copy link
Member

No sensitive information should be in the logs, we can keep the output but passwords should be masked.

#10 C:\xampp\htdocs\directus.test\src\endpoints\Auth.php(49): Directus\Services\AuthService->loginWithCredentials('admin@admin.com', 'xxxxxxxxxxxxx!')
@benhaynes benhaynes added the bug Something isn't working label Nov 1, 2018
@wellingguzman
Copy link
Contributor

As there's no way I can tell whether a data is sensible or not, I went and wrote a small function to normalize the exception almost identical as the Exception::getTraceAsString() based on Exception::getTrace().

What this basically does it tries to replicate the getTraceAsString method, but removing all the arguments, which removes all the arguments passed to any function preventing from reveal any data including sensitive data.

This solution was implemented by ff00728

samvasko pushed a commit to samvasko/api that referenced this issue Nov 25, 2019
* v-input style updates for icons

* Remove color validation
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants