Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation freezes when timer counter overflows (int32, milliseconds since last reboot) #173

Closed
jakeweary opened this issue Feb 8, 2022 · 3 comments · Fixed by #194
Closed
Assignees
Labels
bug Something isn't working

Comments

@jakeweary
Copy link

Had no issues building it on aarch64 but encountered a minor bug: some buttons stuck in hover state (see the attached gif).

The bug appears only on my remote aarch64 server:

$ uname -a
Linux instance-20211022-2042 5.11.0-1021-oracle #22~20.04.1-Ubuntu SMP Fri Oct 22 21:42:24 UTC 2021 aarch64 aarch64 aarch64 GNU/Linux

I've tried to build it locally and it seems to work just fine:

$ uname -a
Linux pc 5.4.72-microsoft-standard-WSL2 #1 SMP Wed Oct 28 23:40:43 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

vtm and gcc versions on both machines:

$ vtm -h
Monotty Desktopio v0.5.9999j

$ gcc --version
gcc (Ubuntu 11.1.0-1ubuntu1~20.04) 11.1.0

Will provide more info if needed. Impressive software btw! 👍

WindowsTerminal_2vKsL2fUm0

@o-sdn-o
Copy link
Collaborator

o-sdn-o commented Feb 8, 2022

This behavior occurs when the system has problems with the timer. This often occurs when the system needs to restart after installing system updates.

Could you please confirm that this is not the case. So far, I have not been able to reproduce it in another way.

UPDATE:
This behavior occurs when the system has problems with the timer. This often occurs when the system uptime is greater than ~1 Month.

@jakeweary
Copy link
Author

Yep, you're totally right, fixed by rebooting. Thanks!

@o-sdn-o o-sdn-o changed the title Buggy hover effect on aarch64 [UI] Animation freezes if the system timer is broken Feb 10, 2022
@o-sdn-o o-sdn-o reopened this Feb 10, 2022
@o-sdn-o
Copy link
Collaborator

o-sdn-o commented Feb 10, 2022

In case of some system failure, std::chrono::steady_clock always returns the same value.

std::chrono::steady_clock::now returns the time point since the last reboot.

e.g.:
1 Month    = 2629800000 Milliseconds
max<int32> = 2147483647

@o-sdn-o o-sdn-o self-assigned this Feb 10, 2022
@o-sdn-o o-sdn-o added the bug Something isn't working label Feb 10, 2022
@o-sdn-o o-sdn-o changed the title [UI] Animation freezes if the system timer is broken [UI] Animation freezes when timer counter overflows (int32, milliseconds since last reboot) Mar 6, 2022
o-sdn-o added a commit that referenced this issue Mar 6, 2022
@o-sdn-o o-sdn-o mentioned this issue Apr 21, 2022
@o-sdn-o o-sdn-o changed the title [UI] Animation freezes when timer counter overflows (int32, milliseconds since last reboot) Animation freezes when timer counter overflows (int32, milliseconds since last reboot) May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants