-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domains in matching context can only trigger with domains but they must not trigger with those characters contained in another domain #433
Comments
related to #429 |
I don't get it or maybe it's just a bad example:
It won't match |
@lutangar I’m not sure about that : For example, notice 373 has matching context 1635 with regex It seems to match with https://lemonde.fr/adobe.com/is-photoshop-lightroom-good We do not have a specific domain check that I know of, since the backend only serve a big regex … We talked about having a list of domains for each MC served in https://notices.bulles.fr/api/v3/matching-contexts, I don’t know if you remember ? Be currently we do not : |
@JalilArfaoui I know which issue we're trying resolve here, @MaartenLMEM example was wrong but he edited since. About the resolution...
This would preserve the kind of "subdomain wildcard" behavior we had so far.
|
I vote for solution 2, as it solves other issues (#405 as you mentionned, but also allow things like dis-moi/extension#277) … and it will also work well with the «XPath replacement» we talked about this morning (no issue created yet ?) |
Alright closing this in favor of #446 then. |
For example
If domain is
jeuxvideo.com
and regex .*forum
It must not match with
https://www.lemonde.fr/pixels/article/2017/11/16/jeuxvideo.com-les-moderateurs-racontent-les-coulisses-du-forum-18-25_5215777_4408996.html
Solution discussed :
/
"The text was updated successfully, but these errors were encountered: