Safari 9 fixes #352
Safari 9 fixes #352
Conversation
|
I installed and tested across a bunch of sites. The only issue I saw is that you don't get a count in the popup for any category that you whitelist. ex. If a page indicates that there are 20 Advertising items being blocked, and then you whitelist Advertising, the popup will now show '0' for Advertising. |
|
@CalMlynarczyk Could you please test it one more time? Updated build is here: https://github.com/tomasko126/disconnect/commit/9c73a6b506a2d037fb76567ce55c14b9d88e4edb |
|
Unfortunately, I'm still seeing the same issue with that new build. Are you seeing it working correctly on your end? Your changes definitely fix the loading issues; I'm trying to see if this "whitelist count" issue already existed, or if there is something we are missing that still needs to get updated. |
|
Can one of the maintainers please review this pull request? |
This PR fixes loading of Disconnect extension on Safari 9 and includes some UX enhancements.