Rewrite JDA readme #2639
Merged
Rewrite JDA readme #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andre601
reviewed
Mar 31, 2024
Andre601
reviewed
Mar 31, 2024
freya022
reviewed
Apr 1, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Given the date, I'm unsure if the most recent commit is a serious one or not... If it is, then I would like to share my opinion that emojis in headers aren't really nice. Especially in GitHub since 1) They are rendered based on the OS, making them inconsistent and 2) Make header-links less intuitive (i.e. Not sure what the opinions of everyone else here is on that tho. |
|
I suggest 🔧 (or 🛠️) instead of🍴 |
| Since you can create your own implementation of `IEventManager`, this is a very versatile and configurable system. | ||
| If the aforementioned implementations don't suit your use-case you can simply create a custom implementation and | ||
| configure it on the `JDABuilder` with `setEventManager(...)`. | ||
| You can find a more thorough example with the [MessageLoggerExample](https://github.com/discord-jda/JDA/blob/master/src/examples/java/MessageLoggerExample.java) class. |
There was a problem hiding this comment.
Perhaps we should also added:
"You can also find the full list of events [here], along with the methods provided by ListenerAdapter [here]
DV8FromTheWorld
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
This rewrites the current README of JDA. Since this README has been around for such a long time, it needed some rework for the current state of the library. I've also heavily reduced the size of the README.