-
-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3: API design review #1340
Draft
foxbot
wants to merge
10
commits into
blank
Choose a base branch
from
next
base: blank
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
v3: API design review #1340
Commits on Jan 5, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 24bcf3b - Browse repository at this point
Copy the full SHA 24bcf3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 523da0b - Browse repository at this point
Copy the full SHA 523da0bView commit details
Commits on Jan 6, 2020
-
incomplete, still needs receive handling gateway is yet to be designed
Configuration menu - View commit details
-
Copy full SHA for f7c212d - Browse repository at this point
Copy the full SHA f7c212dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 97ba033 - Browse repository at this point
Copy the full SHA 97ba033View commit details -
Configuration menu - View commit details
-
Copy full SHA for c51bb4c - Browse repository at this point
Copy the full SHA c51bb4cView commit details -
sample: add idn repl (Interactive Discord.Net)
basic enough to test some stuff with fixed some bugs with disposables in the process
Configuration menu - View commit details
-
Copy full SHA for 0df54c6 - Browse repository at this point
Copy the full SHA 0df54c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 18438e2 - Browse repository at this point
Copy the full SHA 18438e2View commit details -
rest: write out channel model + its dependencies
Optional struct needs work still, + writing the converter for it is going to be a headache
Configuration menu - View commit details
-
Copy full SHA for 5e6f977 - Browse repository at this point
Copy the full SHA 5e6f977View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68f89bf - Browse repository at this point
Copy the full SHA 68f89bfView commit details
Commits on Jan 13, 2020
-
net: add barebones optional converter
does not support property omission at this time, will need to be added later using a separate converter and base marker class. -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 "git failing to recognize gpg key, this identity is still valid" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEErbDRxgZ77MPT+ajAOrLKmA3cYakFAl4bthEACgkQOrLKmA3c YamuWw/7Bn/Ks0mTRN3tg3Z/voETJ/8JQZXJEiW7wwv8c7nSOemxRNB/Tmzo3kzC N6T5fH7Gep4o4iA7CfJ5CZtx+OY92OpyBwsJgkNvANVpjXWCeDaww0Ci5dyVwFUk fFq21l6p2sbM6PB9sEOCvryeIOrgkqBl915MkAlj+/UtnAQ9qFhomIGNLPPFeYOS eaHWjZF6ArbF5NMaOhboDDCIl2nCf+RGEetDoBP2BRaIf+eOyl0lGyQqiY1mNqkD DX8nmcaY5/Lnxhf3pwmYZbqKBPQt5R2FxmqWTg5ey0R4//izE4TJ54nlhdSnTZpH 7ZligmR9rQFdQ5jbSq6cIclo9i988ELHKBgt8mG3SiC4AT0+SBXRpPRBitkA0CPb O4W8J0HrbSFmILx9Zvuy72KC/Zzo+SOS8257S35ihosrlyupcR4zladVcIviAPWk Ovpy85W4uxPdWc6zkMOZSx9OiYFYkNlK/QdNJBXGg7LLcaLf8p33lj+T8UXa7dyC Sw/pW5RL1FYalh7iXF55ylJrKo+oySBejods+ATnmYG4JMywO+GNCE+XLCcDpoBx 9H2z0qJNb5Dgkc4cRulKwYEoT+LQKUhLFdj4wNEqE8mBw0ZoxUiBBqOD1TiZr2mf 1AFQVS/AeOc03t25OfmhNz026OAGy01bjeHr09deT20dsssEpQY= =n76m -----END PGP SIGNATURE-----
Configuration menu - View commit details
-
Copy full SHA for 07f74b7 - Browse repository at this point
Copy the full SHA 07f74b7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.