Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REST V8, Gateway v8 #1038

Merged
merged 34 commits into from
Jul 13, 2021
Merged

REST V8, Gateway v8 #1038

merged 34 commits into from
Jul 13, 2021

Conversation

Khaaz
Copy link
Contributor

@Khaaz Khaaz commented Oct 4, 2020 •
edited
Loading

Ref: discord/discord-api-docs#2097

  • X-Ratelimit-Precision was removed because no longer necessary (all ratelimits are ms by default)
  • guildSubscription is removed because obsolete since intents.
  • Removed deprecated endpoint and methods (GUILD_EMBED)
  • use correct invites endpoint
  • Permissions will still be numbers internally and are parsed as string when create/edit role.
  • Game was removed, replaced by activities[0] for backward compatbility
  • DM channel are no longer sent in CHANNEL_CREATE
  • editGuildMember / editMember now returns the Member (Document "Modify Guild Member" now returns the member on v8 discord/discord-api-docs#2505)

BREAKING CHANGES:

  • getGuildEmbed replaced with getGuildWidget
  • PermissionsOverwrite.type is now a number instead of a String:
    • editChannelPermission is backward compatible
  • member.game was removed, but a getter was ket for backward compatibility

This unfortunately invalidate #1016 ?

Review and testing is appreciated.

@Khaaz Khaaz marked this pull request as ready for review October 11, 2020 14:32
@DonovanDMC
Copy link
Contributor

Just realized by looking back around, I was looking at the wrong thing, and going by what the Discord docs say, those are strings

bsian03
bsian03 requested changes Jan 29, 2021
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
lib/Client.js Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
lib/structures/Guild.js Outdated Show resolved Hide resolved
lib/structures/Guild.js Outdated Show resolved Hide resolved
lib/structures/Member.js Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
lib/Client.js Show resolved Hide resolved
bsian03
bsian03 requested changes Feb 9, 2021
View reviewed changes
Copy link
Collaborator

@bsian03 bsian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GuildIntegration needs to be updated as well, see discord/discord-api-docs#2175

Khaaz and others added 20 commits May 24, 2021 21:23
@Khaaz @bsian03
gateway v8, rest v8
08e31ba
@Khaaz @bsian03
remove deprecated GUILD_EMBED
017445c
@Khaaz @bsian03
Use non deprecated invites/code instead of invite/code
0c7df60
@Khaaz @bsian03
DM_CHANNEL are no longer sent on CHANNEL_CREATE
09ac380
@Khaaz @bsian03
game no longer exists (use activities[0] instead)
2a5c1dd
@Khaaz @bsian03
millisecond precision is now default
32de7e7
@Khaaz @bsian03
permissions are string, type is number
6170eef
@Khaaz @bsian03
correctly adds widgets
d506174
@macdja38 @bsian03
Update getWidget method order to match new linting rules
9b2b75b
@macdja38 @bsian03
Update typescript types
33ade96
@Khaaz @bsian03
remove guildSubscription
b378123
@Khaaz @bsian03
guildSub
030b675
@Khaaz @bsian03
no need for _new fields
957d7aa
@Khaaz @bsian03
editGuildMember now returns Member
3f0f5b1
@Khaaz @bsian03
lint
c7511c5
@Khaaz @bsian03
reordering
fced684
@Khaaz @bsian03
backward compatbility on editChannelPermission
0cd0f34
@Khaaz @bsian03
Update lib/Client.js
db6d155 
Co-authored-by: bsian03 <chharry321@gmail.com>
@Khaaz @bsian03
Update lib/structures/Guild.js
663362f 
Co-authored-by: bsian03 <chharry321@gmail.com>
@Khaaz @bsian03
Update lib/Client.js
73531a4 
Co-authored-by: bsian03 <chharry321@gmail.com>
@bsian03 bsian03 mentioned this pull request Jun 5, 2021
Closed
@LJNeon
Copy link
Contributor

LJNeon commented Jun 26, 2021

This PR doesn't seem to have any logic for the detailed errors added in v8 of the API. I would think we could make some very useful and easy to read errors using that information, and we already have error classes to do that with.

LJNeon
LJNeon reviewed Jun 26, 2021
View reviewed changes
lib/Client.js Outdated Show resolved Hide resolved
@bsian03
Copy link
Collaborator

bsian03 commented Jun 26, 2021

Detailed error handling already exists in DiscordRESTError

@LJNeon
Copy link
Contributor

LJNeon commented Jun 26, 2021

You're right, my bad. I missed that somehow.

bsian03
bsian03 previously requested changes Jul 13, 2021
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
abalabahaha
abalabahaha approved these changes Jul 13, 2021
View reviewed changes
Copy link
Owner

@abalabahaha abalabahaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOLO

@abalabahaha abalabahaha merged commit e194a71 into abalabahaha:dev Jul 13, 2021
@reinacchi reinacchi mentioned this pull request Jul 13, 2021
Merged
@Dramex Dramex mentioned this pull request Jul 23, 2021
Merged
conorwastakenwastaken added a commit to conorwastakenwastaken/eris that referenced this pull request Sep 3, 2021
@conorwastakenwastaken
Squashed commit of the following:
ef632cf 
commit daedb2b
Author: Donovan Daniels <hewwo@yiff.rocks>
Date:   Thu Sep 2 16:40:24 2021 -0500

    Sticker Sending (abalabahaha#1252)

    Co-Authored-By: Catboy <elijahchristopherjohnson@gmail.com>
    Co-authored-by: bsian03 <chharry321@gmail.com>

commit e357991
Author: 5antos <66580910+5antos@users.noreply.github.com>
Date:   Sun Aug 29 23:18:45 2021 +0100

    Enhancements for VoiceChannel join methods (abalabahaha#1195)

    Co-authored-by: Almeida <almeidx@pm.me>
    Co-authored-by: bsian03 <chharry321@gmail.com>

commit 53da0d5
Author: HeadTriXz <32986761+HeadTriXz@users.noreply.github.com>
Date:   Sat Aug 21 22:47:13 2021 +0200

    Better types for events (abalabahaha#1242)

    Co-authored-by: HeadTriXz <headtrixz@outlook.com>

commit 5246da9
Author: abalabahaha <hi@abal.moe>
Date:   Thu Aug 19 13:08:56 2021 +0000

    Bump dev version

commit 6331536
Author: NeTT <56877379+retraigo@users.noreply.github.com>
Date:   Thu Aug 19 18:29:06 2021 +0530

    Pass user data with member in Message constructor (abalabahaha#1260)

    Prevents "User associated with Member not found"

commit a58cd69
Author: bsian03 <chharry321@gmail.com>
Date:   Thu Aug 19 13:55:33 2021 +0100

    Support per-guild avatars (abalabahaha#1219)

commit 21a3ce5
Author: Erin <erin20913@gmail.com>
Date:   Thu Aug 19 08:40:54 2021 -0400

    Add decodeReasons to typings (abalabahaha#1250)

commit 120f917
Author: bsian03 <chharry321@gmail.com>
Date:   Thu Aug 19 13:05:33 2021 +0100

    Expose components (abalabahaha#1189)

    Co-authored-by: HeadTriXz <32986761+HeadTriXz@users.noreply.github.com>
    Co-authored-by: HeadTriXz <32986761+HeadTriXz@users.noreply.github.com>
    Co-authored-by: Tsumari <lucasflicky@hotmail.com>
    Co-authored-by: Catboi <50190590+Catboi8@users.noreply.github.com>

commit 1e95e62
Author: bsian03 <chharry321@gmail.com>
Date:   Thu Aug 19 12:48:23 2021 +0100

    Warn when invalid intent is supplied (abalabahaha#1261)

commit a7bff54
Author: iiFDCT <35053522+iiFDCT@users.noreply.github.com>
Date:   Thu Aug 19 12:46:51 2021 +0100

    Use new permission, intent names (abalabahaha#1257)

commit c31685e
Author: bsian03 <chharry321@gmail.com>
Date:   Thu Aug 19 12:44:57 2021 +0100

    Improve v8 ratelimit handling (abalabahaha#1256)

commit 1e4d78a
Author: bsian03 <chharry321@gmail.com>
Date:   Thu Aug 19 12:28:14 2021 +0100

    Expose audit log events 83-85 (abalabahaha#1213)

    * Audit log types 83-85

    * Update the comment

commit 840227e
Author: bsian03 <chharry321@gmail.com>
Date:   Thu Aug 19 12:19:02 2021 +0100

    Type guild features as actual values (abalabahaha#1212)

commit 4bb65f0
Author: Emad Abdullah <ea@ea.sa>
Date:   Thu Aug 5 00:04:44 2021 +0300

    fix permissions: Value "undefined" is not int for editRole & createRole (abalabahaha#1249)

commit 756943d
Author: Donovan Daniels <hewwo@yiff.rocks>
Date:   Wed Aug 4 15:58:35 2021 -0500

    Fix documentation for create/editRole (abalabahaha#1248)

commit 3d80d20
Author: Ashesh <3626859+Ashesh3@users.noreply.github.com>
Date:   Wed Aug 4 15:10:37 2021 +0530

    Mark ClientOptions in Eris function as required (abalabahaha#1255)

commit ee960c0
Author: bsian03 <chharry321@gmail.com>
Date:   Tue Jul 13 21:25:57 2021 +0100

    Fix possibly undefined member in voiceStateUpdate (abalabahaha#1217)

    Co-authored-by: Erin <erin20913@gmail.com>

commit e194a71
Author: Khaaz <khaaz.dev@gmail.com>
Date:   Tue Jul 13 13:04:21 2021 +0200

    REST v8, Gateway v8 (abalabahaha#1038)

    Co-authored-by: macdja38 <jakeincanada@icloud.com>
    Co-authored-by: bsian03 <chharry321@gmail.com>
    Co-authored-by: abalabahaha <hi@abal.moe>

commit 0726aae
Author: geg <65479041+gegdev@users.noreply.github.com>
Date:   Tue Jul 13 06:35:08 2021 -0400

    Use embeds array in embed example (abalabahaha#1244)

commit 8e9a2b7
Author: Reinhardt <73813638+NotMarx@users.noreply.github.com>
Date:   Tue Jul 13 17:34:33 2021 +0700

    Support sending multiple embeds (abalabahaha#1239)

commit 7e55222
Author: bsian03 <chharry321@gmail.com>
Date:   Mon Jul 12 18:25:00 2021 +0100

    Allow passing a plain object to permissionsOf (abalabahaha#1224)

    Co-authored by: curtisf <caf203@gmail.com>

commit 0abf61a
Author: bsian03 <chharry321@gmail.com>
Date:   Sun Jul 11 12:14:44 2021 +0100

    Expose Guild#nsfwLevel, deprecate Guild#nsfw (abalabahaha#1207)

commit 11d21c9
Author: Avocado <43632131+Awoocado@users.noreply.github.com>
Date:   Wed Jul 7 02:20:21 2021 -0500

    Update Endpoints.js (abalabahaha#1241)

commit d4a49a6
Author: bsian03 <chharry321@gmail.com>
Date:   Tue Jul 6 23:38:36 2021 +0100

    Document disconnecting members from vc better (abalabahaha#1202)

    * Update Member.js

    * Update Guild.js

    * Update Client.js

    * No idea how that happened

commit b483ff3
Author: iiFDCT <35053522+iiFDCT@users.noreply.github.com>
Date:   Tue Jul 6 16:21:56 2021 +0100

    Update sticker properties (abalabahaha#1237)

    * Use `sticker_items`

    * Docs

    * Update docs

    * Deprecate `stickers`, use `sticker_items`

    * Add user to cache

    * Empty string

    * Use camelCase

    * Wrong func

    * Docs

    * Add back useless property

    * Pretend like this variable ever gets defined

    * Newlines

commit 15546c4
Author: bsian03 <chharry321@gmail.com>
Date:   Mon Jul 5 22:53:50 2021 +0100

    Make purgeChannel use getMessages options (abalabahaha#1236)
bsian03 added a commit to bsian03/eris that referenced this pull request Oct 10, 2021
@Khaaz @macdja38
@bsian03 @abalabahaha
REST v8, Gateway v8 (abalabahaha#1038)
e4f519b 
Co-authored-by: macdja38 <jakeincanada@icloud.com>
Co-authored-by: bsian03 <chharry321@gmail.com>
Co-authored-by: abalabahaha <hi@abal.moe>
@abalabahaha abalabahaha added this to the 0.16.0 milestone Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonovanDMC DonovanDMC DonovanDMC left review comments

@LJNeon LJNeon LJNeon left review comments

@abalabahaha abalabahaha abalabahaha approved these changes

@bsian03 bsian03 bsian03 left review comments

Assignees
No one assigned
Labels
Discord
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Khaaz @DonovanDMC @LJNeon @bsian03 @abalabahaha @macdja38