use correct colorspace in avcodec #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikepavone
approved these changes
Oct 27, 2022
| @@ -300,6 +300,9 @@ static int avcodec_decoder_copy_frame(const avcodec_decoder d, opencv_mat mat, A | |||
| NULL, | |||
| NULL, | |||
| NULL); | |||
| const int *src_coeffs = sws_getCoefficients(frame->colorspace); | |||
| const int *dst_coeffs = sws_getCoefficients(0); | |||
There was a problem hiding this comment.
I wonder if it would make more sense to specify SWS_CS_ITU709 (which evals to 1) here rather than 0 (which has no #define but appears to use the same coefficients as SWS_CS_ITU709).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.