Remove unreachable code in thumbhash_encoder_create (#129) #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,9 +16,6 @@ struct thumbhash_encoder_struct { | |||
| thumbhash_encoder thumbhash_encoder_create(void* buf, size_t buf_len) | |||
| { | |||
| thumbhash_encoder e = new struct thumbhash_encoder_struct(); | |||
There was a problem hiding this comment.
@skidder wouldn't it be better to enclose this into a try-catch block? If the std::bad_alloc is encountered, we should catch it and return NULL since the function is already designed in a way that it returns NULL when new fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #129