-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Rest): switch queue to AsyncQueue #4835
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotSugden
reviewed
Sep 20, 2020
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
iCrawl
approved these changes
Sep 22, 2020
papaia
reviewed
Sep 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't AsyncQueue be a private class?
vladfrangu
approved these changes
Sep 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless we want to wait a bit more for v13's rest, LGTM
SpaceEEC
approved these changes
Sep 25, 2020
5 tasks
GiorgioBrux
pushed a commit
to GiorgioBrux/discord.js
that referenced
this pull request
Oct 1, 2020
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
GiorgioBrux
pushed a commit
to GiorgioBrux/discord.js
that referenced
this pull request
Oct 17, 2020
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
AGuyNamedJens
added a commit
to AGuyNamedJens/discord.js
that referenced
this pull request
Oct 26, 2020
(backported from discordjs/discord.js#4835)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Better alternative to #2744.
When running the following code as an example
message.channel.send();
, REST gives us this stack trace:After this patch, it returns this one:
Which correctly points to where I ran my eval command (same code before and after this patch).
Typings are unpatched until further decision from the team on whether we should use discord.js v13's core package (once released, will come with its typings), or stick with this implementation in the meantime.
There are a few modifications needed for this to work, but since the modified properties were inside the library's internals (which are private), I believe this falls under
semver: patch
, and we can ship this in v12.4.What is better about this compared to the previous system?
AbortError
, which can fix 2 issues in one go.reject()
, with this patch, it'd bubble up, and atry
/finally
takes care of resuming the queue.Status
Semantic versioning classification: