-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Rest): resolved a regression, added retried AbortError #4852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladfrangu
requested changes
Sep 26, 2020
vladfrangu
approved these changes
Sep 26, 2020
favna
approved these changes
Sep 26, 2020
iCrawl
approved these changes
Sep 27, 2020
SpaceEEC
approved these changes
Sep 27, 2020
please push this, we badly need a fix for #3471 |
There's no rush, giving time before merging helps getting more eyes on it, which can lead to more people trying it out. The more, the better, as they can find issues we didn't. This PR will be included in the 12.4.0 release, that's for sure :) |
GiorgioBrux
pushed a commit
to GiorgioBrux/discord.js
that referenced
this pull request
Oct 1, 2020
GiorgioBrux
pushed a commit
to GiorgioBrux/discord.js
that referenced
this pull request
Oct 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
#4835 introduced a regression in 4xx errors, the following chunks of code are not identical - the old one rejected with DiscordAPIError if there was a 4xx error, but the new one throws, and then re-throws but as a HTTPError:
discord.js/src/rest/RequestHandler.js
Lines 167 to 175 in 7b38f46
discord.js/src/rest/RequestHandler.js
Lines 150 to 158 in 169d4c3
My apologies for anyone affected, even though nobody reported this issue (yet) since the names and properties are nearly identical for error handlers that don't check for
instanceof
. But the good news, retried AbortErrors!Stack Traces and Types
Running the following code, and using
@klasa/type
to retrieve the output's type in eval:Before this patch:
Type:
The type is incorrect, the error thrown must be an instance of DiscordAPIError if it's related to an error thrown from the API.
After this patch:
Type:
With this patch, the error's type is the correct one.
Fixes #3471
Status
Semantic versioning classification: