-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(User): banners and accent colors #6117
Conversation
don't mind it for now, just trying
|
Discord will make banner_color an integer instead of a string to be consistent with other colors; this PR will be updated when that change is live |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be better to do it like this?
this.banner = {
url: "url",
color: "Hex"
}
pretty sure it's not like that for consistency with other properties/methods |
So, you know, I say that because it would be good if it was the same everywhere. With embed footer you have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
This needs a rebase. |
upstream PR has been merged 🎉 |
Why doesn't this PR support banner_color? |
because accent_color replaces banner_color, the old one will be removed |
But it seems like one represents the HEX color and the other one is the base-10 color, are you sure it's gonna be removed? |
yes, banner_color was the original one but we got it changed to base 10 to be consistent with the other colors in the api |
Co-authored-by: Rodry <38259440+ImRodry@users.noreply.github.com>
Co-authored-by: Rodry <38259440+ImRodry@users.noreply.github.com>
Can't find |
You probably just need to switch to the main branch |
It's not in stable yet. You'll need to select the |
Please describe the changes this PR makes and why it should be merged:
This PR is a continuation of #5930
Adds User#banner, User#bannerURL(), User#accentColor, and User#hexAccentColor (all require the user to be force fetched)
Sinceaccent_color
is currently only implemented in the canary API, you must addhttp: {headers: {'x-debug-options': 'canary'}}
orhttp: {api: 'https://canary.discord.com/api'}
to your ClientOptions to test accentColor/hexAccentColorPR documenting this on Discord's end: discord/discord-api-docs#3448
Status and versioning classification: