Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use globally available WebSocket client in runtimes that have it #10042

Merged

Conversation

vladfrangu
Copy link
Member

@vladfrangu vladfrangu commented Dec 9, 2023

Please describe the changes this PR makes and why it should be merged:

Bun fixed the WebSocket issue (oven-sh/bun#3392). WS now reports correct close codes and everything! Now, fingers crossed their WebSocket client doesn't have some hidden bugs 🤞

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vladfrangu vladfrangu requested a review from a team as a code owner December 9, 2023 20:23
Copy link

vercel bot commented Dec 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Dec 9, 2023 8:23pm
discord-js-guide ⬜️ Ignored (Inspect) Dec 9, 2023 8:23pm

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (54453b0) 58.45% compared to head (a234c54) 58.44%.
Report is 5 commits behind head on main.

Files Patch % Lines
packages/ws/src/ws/WebSocketShard.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10042      +/-   ##
==========================================
- Coverage   58.45%   58.44%   -0.02%     
==========================================
  Files         241      241              
  Lines       17130    17128       -2     
  Branches     1241     1242       +1     
==========================================
- Hits        10014    10010       -4     
- Misses       7071     7073       +2     
  Partials       45       45              
Flag Coverage Δ
next ∅ <ø> (∅)
ws 52.49% <50.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jiralite Jiralite added this to the ws 1.1.0 milestone Dec 10, 2023
@kodiakhq kodiakhq bot merged commit 319ef9a into main Dec 10, 2023
23 checks passed
@kodiakhq kodiakhq bot deleted the feat/use-globalThis.websocket-in-envs-with-it-available branch December 10, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants