-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types(DirectoryChannel): Ensure directory channels cannot contain user mentions when stringified #10043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
vladfrangu
approved these changes
Dec 10, 2023
SpaceEEC
approved these changes
Dec 10, 2023
Jiralite
force-pushed
the
types/directory-channel-mention
branch
from
December 18, 2023 22:25
eb9b366
to
10cab26
Compare
almeidx
approved these changes
Dec 18, 2023
This was referenced Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Directory channels when stringified cannot possibly be a user mention (which is typed through the inheritance chain):
discord.js/packages/discord.js/typings/index.d.ts
Line 2901 in 1f5d71e
discord.js/packages/discord.js/typings/index.d.ts
Lines 938 to 955 in 1f5d71e
Also added tests for the remaining channels.
Status and versioning classification: