Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix for kick reason #1489

Closed
wants to merge 31 commits into from
Closed

Hotfix for kick reason #1489

wants to merge 31 commits into from

Conversation

PgBiel
Copy link
Contributor

@PgBiel PgBiel commented May 14, 2017 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:
This is a quick fix for kick reasons. While I do know that this will be switched to headers later, it's better to keep this hotfix for now. It's basically to escape the reason. Without this escaping, special characters get messed up and writing things like # would cancel everything after it.
P.S.: This should be applied to master and 11.1-dev.

Edit: This should be only applied to 11.1-dev (The fix for this is going to be in 12.0.0)

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

devsnek and others added 30 commits May 1, 2017 20:37
@devsnek @amishshah
Add Guild#nameAcronym and make avatar/iconURLs into functions (discor…
35ef9cd 
…djs#1144)

* Guild#iconURL(format, size);
* OAuth2Application#iconURL(format, size);
* User#iconURL(format, size);
@CodeMan99 @amishshah
Document flattenErrors keys param (discordjs#1447)
e124ada 
* Document flattenErrors keys param.

* Remove parens.

* Capitalise a letter
@amishshah
Improve GuildAuditLogs documentation by creating an AuditLogChange ty…
7da53af 
…pedef
@amishshah
watch me, gus
b7a81ed
@amishshah
New is also optional
a7c902c
@SpaceEEC @amishshah
Fix for sending files with Webhook class (discordjs#1449)
07623d4
@amishshah
Fix typo in RESTMethods.js (discordjs#1454)
3d92c6d 
fetchMeMentions -> fetchMentions 🤔
@amishshah
Fix typo in RESTMethods.js (discordjs#1455)
ac5d4d1 
Mentions should be written with a capital M
@devsnek @iCrawl
Update GuildAuditLogs.js (discordjs#1456)
caf9633
@iCrawl
Update welcome docs page
8c6167d
@SpaceEEC @iCrawl
Endpoints.Guild(...).Emoji(...) should not use CDN (discordjs#1462)
e643738
@iCrawl
Update version
2a23941
@SpaceEEC @iCrawl
update GuildAuditLogs for MESSAGE_DELETE and fixed extras (discordjs#…
128b4ee 
…1464)

* update GuildAuditLogs for MESSAGE_DELETE and fixed extras

* correct oder of targets
@SpaceEEC @iCrawl
readded docs for Client#error and Client#ready (discordjs#1466)
a4e5713
@SpaceEEC @iCrawl
using correct properties for invites (discordjs#1467)
a685d24
@SpaceEEC @iCrawl
added Invite#presenceCount and Invite#memberCount (discordjs#1460)
d9e5bde 
* added Invite#online and Invite#memberCount

* requested change
@SpaceEEC @iCrawl
fix fetchMentions' auth header, options and data mapping (discordjs#1457
e66fa14 
)

* fix fetchMentions' auth header, options and data mapping

* vscode strikes again

* switched to Util.mergeDefault

* vscode

* removed duplicated optionals and switched to instanceof
@SpaceEEC @iCrawl
Using a traditional for loop rather than a for in loop for options.fi…
5bfc688 
…les (discordjs#1461)
@1Computer1 @iCrawl
Deprecate aliases (discordjs#1469)
6566c0d
@SpaceEEC @iCrawl
Handing promise rejections from GuildAuditLogs#build to the user (dis…
f95f18b 
…cordjs#1474)

* handing guildauditlog's promise rejections to the user

* Returning a new Promise to resolve a Promise.all is unnecessary.
Also for the docs, it returns a Promise<GuildauditLogs>, not GuildAuditLogs directly.

* totally did not removed that line
@meew0
Fix the mention example in the USERS_PATTERN doc comment
83f2c62 
Previously it was a channel mention. Thanks @Hackzzila.
@Drahcirius @Gawdl3y
invalid token errors not rejected properly (discordjs#1478)
d11a658 
* ready event will now throw errors properly

* ws login rejection fix
@aemino @iCrawl
GuildMember#setVoiceChannel fix (discordjs#1482)
ff82297 
Looks like someone forgot to remove the full channel object from the PATCH payload.
@SpaceEEC @iCrawl
Failing to resolve a role should reject and not throw an error (disco…
ff3e602 
…rdjs#1483)
@devsnek @iCrawl
make default avatar resolving better (discordjs#1484)
6ac2252 
* Update Constants.js

* Update User.js

* Update Constants.js

* Update Constants.js
@iCrawl
Fix webpack uglify
b0d4b53
@iCrawl
Add tarvis staging
eab5c9e
@iCrawl
Improve test and build scripts
b464568
@iCrawl
Move node versions
833bfa1
@iCrawl
Update travis build stages
5db3ab7
@PgBiel
Copy link
Contributor Author

PgBiel commented May 14, 2017

Seeing that v12 will have the fix (Assuming it will be done in #1490), this should probably be applied to 11.1-dev.

@PgBiel PgBiel changed the base branch from master to 11.1-dev May 14, 2017 22:23
@PgBiel PgBiel closed this May 14, 2017
@PgBiel
Copy link
Contributor Author

PgBiel commented May 14, 2017

:|

@PgBiel PgBiel deleted the hotfix-kick branch May 14, 2017 22:23
@PgBiel PgBiel changed the base branch from 11.1-dev to master August 20, 2017 23:58
@snyk-bot snyk-bot mentioned this pull request Jul 31, 2022
Open
@J3ermuda J3ermuda mentioned this pull request Jul 31, 2022
Open
@M0diis M0diis mentioned this pull request Jul 31, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jul 31, 2022
Open
@RoyallarsYTVIP RoyallarsYTVIP mentioned this pull request Aug 1, 2022
Open
This was referenced Aug 1, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@PgBiel @iCrawl @devsnek @CodeMan99 @amishshah @SpaceEEC @1Computer1 @meew0 @Drahcirius @aemino