Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional AuditLog Events #3584

Merged
merged 4 commits into from
Nov 19, 2019
Merged

Additional AuditLog Events #3584

merged 4 commits into from
Nov 19, 2019

Conversation

Fyko
Copy link
Contributor

@Fyko Fyko commented Nov 19, 2019 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:
This adds additional Audit Log events per #1191.

credit to tipaka for pointing this out

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@Fyko
adds more audit-log entries
7fdcf34 
this adds additional audit-log types from https://discord/discord-api-docs/pull/1191
@Fyko Fyko changed the title Additional AuditLog Entries Additional AuditLog Events Nov 19, 2019
appellation
appellation suggested changes Nov 19, 2019
View reviewed changes
Copy link
Member

@appellation appellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typings need to be updated.

@Khaaz
Copy link
Contributor

Khaaz commented Nov 19, 2019

@Fyko The actual values for integrations events are 80, 81, 82. Just updated it, my bad.

@SpaceEEC SpaceEEC merged commit 1bcc0c2 into discordjs:master Nov 19, 2019
@Fyko Fyko deleted the patch-2 branch November 19, 2019 23:59
@SpaceEEC SpaceEEC mentioned this pull request Nov 28, 2019
Merged
5 tasks
@RDambrosio016 RDambrosio016 mentioned this pull request Dec 21, 2019
Closed
@monbrey monbrey mentioned this pull request Feb 1, 2020
Merged
5 tasks
samsamson33 pushed a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
@Fyko @samsamson33
feat(GuildAuditLogs): add new event types (discordjs#3584)
3c0a516 
* adds more audit-log entries

this adds additional audit-log types from https://discord/discord-api-docs/pull/1191

* typings for new audit-log entries

* typings for new audit-log entries

* fix action numbers
samsamson33 added a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
@samsamson33
Revert "feat(GuildAuditLogs): add new event types (discordjs#3584)"
95f37e7 
This reverts commit 3c0a516.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appellation appellation appellation requested changes

@MBR-0001 MBR-0001 MBR-0001 approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Fyko @Khaaz @appellation @SpaceEEC @MBR-0001