Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PermissionOverwrites): resolveOverwriteOptions description #4088

Merged
merged 1 commit into from
Apr 16, 2020
Merged

fix(PermissionOverwrites): resolveOverwriteOptions description #4088

merged 1 commit into from
Apr 16, 2020

Conversation

withmask
Copy link
Contributor

@withmask withmask commented Apr 15, 2020

Please describe the changes this PR makes and why it should be merged:
This pr changes resolveOverwriteOptions description to be more appriopriate to what it does.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@RDambrosio016
Copy link
Contributor

Branch needs to be changed from stable to master and the breaking changes box needs to be unchecked as this is not breaking

@SpaceEEC SpaceEEC changed the base branch from stable to master April 15, 2020 14:57
@withmask
Copy link
Contributor Author

Unchecked the breaking changes box, miss click 😁

@iCrawl iCrawl changed the title Fix resolveOverwriteOptions description. fix(PermissionOverwrites): resolveOverwriteOptions description Apr 16, 2020
@iCrawl iCrawl merged commit d709656 into discordjs:master Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants