refactor(Presences): remove from User, nullable on GuildMember #6055
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as well as on Client#presenceUpdate
Please describe the changes this PR makes and why it should be merged:
This PR:
User#presence
as it was a hack traversing the guild cache in order to find a presence of any member representing the given user.GuildMember#presence
nullable. That way you can distinguish between "This member is offline" and "The presence of this member is unknown" without having to check the cache yourself, rendering this getter pointless.Additionally this was confusing when you did not enable the presence intent in the first place: "Why do I know this member is offline? I am not supposed to know!" (Despite you actually having no idea)
Client#presenceUpdate
first parameternull
instead ofundefined
, because we don't do this in other places and an explicit null makes more sense than undefined.Status and versioning classification: