refactor: added TextBasedChannels
type
#6286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
At the moment, if Discord adds a new channel type, we have to update the types in many places, this creates issues as far as the type consistency go, such as
MessageCollector
not acceptingNewsChannel
as a valid channel type.I also considered #6262 as an alternative fix for this, however, a generic type doesn't have many of the benefits from an union, such as being able to exclude certain types (
channel.guild ? <channel is TextChannel | NewsChannel | ThreadChannel> : <channel is DMChannel | PartialDMChannel>
).I also made a typedef in the JavaScript side so the documentation for it is readily available in the documentation website, and refactored the TS type for
TextBasedChannelTypes
to read the new type'stype
field, so any change we do toTextBasedChannels
will reflect on it.Status and versioning classification: