-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: general cleanup and improvements #6299
Conversation
Co-authored-by: DaStormer <40336269+DaStormer@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the changes requested 👍
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
|
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
The CI is just broken today apparently |
There seems to be a partial outage, although the workflow is now at least queued. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the requested changes, LGTM
Some textual errors in this PR, namely writing id instead of ID. |
Both are fine but if you wanted that changed you should’ve probably said that before merge |
|
Please describe the changes this PR makes and why it should be merged:
I went through every page on the docs and added/fixed some things. Although the title says docs this does include very small changes to the typings and code which I will be detailing below and you're welcome to give your opinion on them if you believe they should be reverted.
RELAY_ENABLED
guild feature as it was not found on the docsGuild#preferredLocale
as nullable since a Guild may not have community enabledMANAGED_EMOJI
,GROUP_DM_CREATE
andRPC_HAS_CONNECTED
Application flags as they could not be found on the docsAlong with those, here are the other changes:
Application
Webhook type@external
linkstring
types where they should beSnowflake
@returns
descriptionsImageSize
type toAllowedImageSize
for consistency and assigned it to all CDN endpoint sizes (change previously suggested in feat(GuildMember): add guild avatars #5696 but might as well do it now).Status and versioning classification: