Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: nullify guildScheduledEventUpdate's old parameter #7955

Merged
merged 1 commit into from
May 21, 2022
Merged

types: nullify guildScheduledEventUpdate's old parameter #7955

merged 1 commit into from
May 21, 2022

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
oldGuildScheduledEvent is potential null. This was reflected in the documentation, but not in the typings.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@Jiralite Jiralite changed the title types: nullify GuildScheduledEvent's old parameter types: nullify guildScheduledEventUpdate's old parameter May 20, 2022
@SpaceEEC SpaceEEC added this to the discord.js v14 milestone May 20, 2022
@iCrawl iCrawl merged commit fdeac9d into discordjs:main May 21, 2022
@Jiralite Jiralite deleted the types/null-old-event branch May 21, 2022 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
packages:discord.js semver:patch typings
Projects
discord.js
Archived in project
Milestone
discord.js v14
Development

Successfully merging this pull request may close these issues.
5 participants
@Jiralite @vladfrangu @iCrawl @kyranet @SpaceEEC