types(AutocompleteOption): fix and improve types #8069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
almeidx
reviewed
Jun 11, 2022
|
In a weird twist of events it turns out value is always a string when an option is focused and, since this interface is only used for focused autocomplete options I went ahead and changed that type and its name |
Jiralite
approved these changes
Jun 11, 2022
Jiralite
requested changes
Jun 11, 2022
Co-Authored-By: Almeida <almeidx@pm.me>
ImRodry
force-pushed
the
types/autocompleteoption-fix
branch
from
5a50155
to
1d6d1cd
Compare
vladfrangu
approved these changes
Jun 12, 2022
SpaceEEC
approved these changes
Jun 12, 2022
kyranet
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
The type of AutocompleteOption#value was wrong so I went ahead and fixed that and also made the other properties more accurate (made focused not optional and type more specific).
Status and versioning classification: