-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Sticker): add support for gif stickers #9038
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
5990eb3
to
08a6310
Compare
Codecov Report
@@ Coverage Diff @@
## main #9038 +/- ##
==========================================
- Coverage 84.11% 84.11% -0.01%
==========================================
Files 108 108
Lines 9489 9488 -1
Branches 1113 1113
==========================================
- Hits 7982 7981 -1
Misses 1466 1466
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits, the map is a pseudo-enum, so it needs to be named in PascalCase, as the rest of the constants from the Constants file (https://github.com/discordjs/discord.js/blob/05a1cbfe5479195b0bc9b6f0971fe39f6af6fd77/packages/discord.js/src/util/Constants.js).
Also, shouldn't we export this (in the Constants
file) so users can map the extensions themselves?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I Ctrl+Enter'd instead of clicking "Request changes". ↑
8aa12a7
to
b676bcc
Compare
b676bcc
to
7bc1221
Compare
Please describe the changes this PR makes and why it should be merged:
Upstream:
Depends on:
GIF
discord-api-types#688Status and versioning classification: