Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(InteractionResponses): showModal docs change #9434

Merged
merged 5 commits into from
Apr 21, 2023

Conversation

anandre
Copy link
Contributor

@anandre anandre commented Apr 20, 2023

Please describe the changes this PR makes and why it should be merged: Updates the various showModal docs so it's showing the acceptable parameters

Status and versioning classification: v14

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Update the parameters for the showModal method
Add APIModalInteractionResponseCallbackData link for docs link for showModal method
@anandre anandre requested a review from a team as a code owner April 20, 2023 21:14
@vercel
Copy link

vercel bot commented Apr 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Apr 20, 2023 9:44pm
discord-js-guide ⬜️ Ignored (Inspect) Apr 20, 2023 9:44pm

@Jiralite Jiralite added this to the discord.js 14.10 milestone Apr 20, 2023
@anandre anandre changed the title Modal docs change showModal docs change Apr 20, 2023
Change the order of parameters so the ModalBuilder is listed first
Disable the ESline line length rule for the APITypes file
@anandre anandre changed the title showModal docs change docs(InteractionResponses): showModal docs change Apr 20, 2023
Add ModalComponentData to the JSDoc, it was omitted before.
@kodiakhq kodiakhq bot merged commit 7d34100 into discordjs:main Apr 21, 2023
@anandre anandre deleted the modal-docs-change branch April 21, 2023 13:14
didinele pushed a commit that referenced this pull request Apr 21, 2023
* Update InteractionResponses.js

Update the parameters for the showModal method

* Update APITypes.js

Add APIModalInteractionResponseCallbackData link for docs link for showModal method

* Update InteractionResponses.js

Change the order of parameters so the ModalBuilder is listed first

* Update APITypes.js

Disable the ESline line length rule for the APITypes file

* Update InteractionResponses.js

Add ModalComponentData to the JSDoc, it was omitted before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants