refactor(ShardClientUtil): logic de-duplication #9491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added docs to the `calculateShardId` function
almeidx
requested review from
vladfrangu,
iCrawl,
kyranet,
didinele,
Jiralite,
suneettipirneni and
SpaceEEC
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
suneettipirneni
approved these changes
May 1, 2023
kyranet
approved these changes
May 1, 2023
Jiralite
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
🤖 Generated by Copilot at 4b576b6
Summary
🚚🔧🧹
This pull request refactors the sharding logic of
discord.jsto use a common functioncalculateShardIdfrom the@discordjs/shardingpackage, which improves code quality and maintainability. It also moves the function definition from theutilpackage to theshardingpackage, which reduces the API surface and the risk of breaking changes.Walkthrough
calculateShardIdfunction fromutiltoshardingpackage (link)calculateShardIdfunction from@discordjs/shardinginShardClientUtil.js(link)calculateShardIdfunction call inShardClientUtil.js(link)Status and versioning classification: