fix: button for outline on small screens #9965
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9965 +/- ##
==========================================
- Coverage 59.01% 58.62% -0.40%
==========================================
Files 241 240 -1
Lines 16968 17049 +81
Branches 1241 1240 -1
==========================================
- Hits 10014 9995 -19
- Misses 6909 7009 +100
Partials 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
iCrawl
requested changes
Nov 15, 2023
…ix/outline-mobile
iCrawl
reviewed
Nov 18, 2023
Comment on lines
21
to
23
| className={`fixed block bottom-4 top-22 z-20 mx-auto max-w-5xl border border-light-900 rounded-md bg-white/75 shadow backdrop-blur-md transition-all duration-300 ${ | ||
| opened ? 'left-4 right-4 ' : 'left-full -right-[calc(100vw_-_32px)]' | ||
| } lg:sticky lg:block lg:h-full lg:max-w-xs lg:min-w-xs lg:w-full dark:border-dark-100 dark:bg-dark-600/75`} |
There was a problem hiding this comment.
This doesn't make any sense.
block and lg:block are both applied at the same time here basically, you also removed the hidden class if its not opened.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Adds button in header to expand table of contents on smaller screens.
Status and versioning classification: