Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(website): remove unneccessary addPackageToModel function #9983

Merged
merged 9 commits into from
Nov 21, 2023

Conversation

Qjuh
Copy link
Contributor

@Qjuh Qjuh commented Nov 18, 2023

Please describe the changes this PR makes and why it should be merged:

  • Removed the addPackageToModel function as it now was a one-liner that can be done directly where needed.
  • fixed event links from search index

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Copy link

vercel bot commented Nov 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Nov 18, 2023 2:15pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Nov 18, 2023 2:15pm

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (802ec63) 58.94% compared to head (ae378bf) 58.96%.

Files Patch % Lines
.../docs/packages/[package]/[version]/[item]/page.tsx 0.00% 5 Missing ⚠️
...c/app/docs/packages/[package]/[version]/layout.tsx 0.00% 3 Missing ⚠️
apps/website/src/util/fetchMember.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9983      +/-   ##
==========================================
+ Coverage   58.94%   58.96%   +0.02%     
==========================================
  Files         241      240       -1     
  Lines       16988    16982       -6     
  Branches     1241     1240       -1     
==========================================
  Hits        10014    10014              
+ Misses       6929     6923       -6     
  Partials       45       45              
Flag Coverage Δ
utilities 100.00% <ø> (ø)
website 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Qjuh Qjuh requested a review from a team as a code owner November 18, 2023 12:02
@iCrawl iCrawl merged commit 3d1c884 into discordjs:main Nov 21, 2023
22 checks passed
@Qjuh Qjuh deleted the fix/deprecated-links-d.ts branch November 23, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants