python3 port #48
Merged
python3 port #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasWaldmann
force-pushed
the
py3
branch
2 times, most recently
from
228bd71
to
c595501
Compare
Closed
also: try to be effective by preferring the iterators (not full lists).
but keep __nonzero__ as alias for py2.
bytestring_type(int) was a bug on py3, because e.g. bytes(0) creates a 0-bytes long b'', not b'0'. On py2, str(0) did what was expected.
after disabling it, a whole bunch of new test failures shows up. wtf?
also: renamed _unicode_keyed() to _transform_keys(). the original port to py3 was incorrect here, we need to call that function for both py2 and py3. on py2 it transforms keys to unicode AND strips trailing '_'. on py3 it only strips trailing '_'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yay, all tests working!