FEATURE: Add group and category restriction to house ads

[janzenisaac]

Description

This PR adds the ability to apply group and category restrictions to a house ad.

What is included

• In order to get the group and category selectors to work within admin/assets/javascripts/discourse/controllers/admin-plugins-house-ads-show.js I needed to modernize the file.
• I dropped the bufferedProperty implementation in favor of a vanilla ember approach
• I added category_ids and group_ids to our house ads model
• I added tests for group / category restrictions
• I added a preview button to display the house ad
• /site.json would return a object called house_creatives and a list of key value pairs that matched the ad name with the html, like so:

{ AD_KEY: ad.html }

I need access to the category ids on the client to conditionally render the house ads so the new format will be:

{ AD_KEY: { html: ad.html, category_ids: ad.category_ids } }

Screenshots

Preview Video

preview.mov

[markvanlan]

A couple tiny things -- only question I had on specs were, is there coverage for making sure that anon-allowed ads do show for logged in users? Approving :)

[markvanlan]

I believe you could change this to a fn get savingText that tracks saving to make it a bit easier to follow

[janzenisaac]

We have three different states for savingStatus

• ""
• "saving"
• "saved"

I think we will need to keep it as is, so that we can set the saving status during the ajax call. OR we drop the saving status and just have two states, "" or saved then move it to a getter.

[janzenisaac]

When a ad is set to visible_to_logged_in_users: false and visible_to_anons: true we don't display the ad to authenticated users.

[janzenisaac]

When a ad has visible_to_logged_in_users: true and visible_to_anons: true we do display the ad for authenticated users