New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: allow plugins to extend Groups #14216

Merged

lis2 merged 5 commits into discourse:main from lis2:groups-adjustments-for-assign

Sep 6, 2021

Contributor

lis2 commented Sep 2, 2021 •

edited

Loading

This PR contains 3 features. Each one is a separate commit to make it easier to review:

Allow plugins to define permitted parameter for groups. If a plugin is adding a column to the groups table, we need to allow plugins to permit those new parameters to create/update Group.
Outlet groups-interaction-custom-options for group interaction fields. Plugin can add new fields to the Group form
User chooser can have a custom scope to filter returned groups

Correlated PR discourse/discourse-assign#195

lis2 mentioned this pull request

FEATURE: new assignable group option instead of messageable discourse/discourse-assign#195

Merged

tgxworld reviewed

View reviewed changes

spec/requests/users_controller_spec.rb Outdated Show resolved Hide resolved

tgxworld reviewed

View reviewed changes

app/controllers/groups_controller.rb Outdated Show resolved Hide resolved

tgxworld reviewed

View reviewed changes

spec/requests/admin/groups_controller_spec.rb Outdated Show resolved Hide resolved

lis2 requested a review from tgxworld

September 2, 2021 04:27

tgxworld reviewed

View reviewed changes

lib/plugin/instance.rb Show resolved Hide resolved

tgxworld reviewed

View reviewed changes

app/controllers/users_controller.rb Outdated Show resolved Hide resolved

lis2 requested a review from tgxworld

September 5, 2021 22:46

martin-brennan approved these changes

View reviewed changes

lis2 added 5 commits

September 6, 2021 09:26


          FIX: add_permitted_group_param api for plugins

ba8b00b


          FIX: add groups-interaction-custom-options outlet

e717764


          FIX: custom search can use custom group scope

d6531fe


          FIX: improvements after code review

1cf4333


          FIX: move custom scope logic to Group.search

700d560

lis2 force-pushed the groups-adjustments-for-assign branch from 336b81b to 700d560 Compare

September 5, 2021 23:48

lis2 merged commit f859fd6 into discourse:main

lis2 deleted the groups-adjustments-for-assign branch

September 6, 2021 00:18

lis2 added a commit to lis2/discourse that referenced this pull request


          FIX: better filter for groups search

3c4b7b9

Follow up of discourse#14216

Allow plugins to register custom filter with block

lis2 mentioned this pull request

FIX: better filter for groups search #14255

Closed

lis2 mentioned this pull request

FIX: better filter for groups search #14262

Merged

lis2 added a commit to lis2/discourse that referenced this pull request


          FIX: better filter for groups search

83bacff

Follow up of discourse#14216

Allow plugins to register custom filter with block

lis2 added a commit that referenced this pull request


          FIX: better filter for groups search (#14262)

e3793e6

Follow up of #14216

Allow plugins to register custom filter with block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet