Specify PA, dRA sign conventions #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should it be added to the docs pages somewhere too? |
mtazzari
requested changes
Mar 12, 2021
frank/parameter_descriptions.json
Outdated
| "pa" : "Position angle, unit=[deg]", | ||
| "dra" : "Delta (offset from 0) right ascension, unit=[arcsec]", | ||
| "pa" : "Position angle, defined east of north, unit=[deg]", | ||
| "dra" : "Delta (offset from 0) right ascension, defined east of north, unit=[arcsec]", |
There was a problem hiding this comment.
Suggested change
| "dra" : "Delta (offset from 0) right ascension, defined east of north, unit=[arcsec]", | |
| "dra" : "Delta (offset from 0) right ascension, defined positive for offsets towards East, unit=[arcsec]", |
There was a problem hiding this comment.
Good point, fixed in bbda275
frank/geometry.py
Outdated
| @@ -19,7 +19,8 @@ | |||
| """This module contains methods for fitting a source's geometry and deprojecting | |||
| the visibilties by a fitted or a given geometry. | |||
|
|
|||
| NOTE: The sign convention used here is xx. | |||
| NOTE: The sign convention used here is east of north for position angle (PA) | |||
| and right ascension offset (dRA). | |||
There was a problem hiding this comment.
Suggested change
| and right ascension offset (dRA). | |
| and positive right ascension offset (dRA) for offset towards East. |
There was a problem hiding this comment.
Fixed in bbda275
mtazzari
reviewed
Mar 12, 2021
| @@ -97,7 +97,7 @@ | |||
| "metadata": {}, | |||
| "source": [ | |||
| "Before fitting the radial brightness profile, we need to determine the disc's geometry (inclination, position angle and phase center) in order to deproject the visibilities (recall that frank, fitting in 1D, assumes an axisymmetric source).\n", | |||
| "To do this we pass an object specifying how the geometry is determined to the [FrankFitter](../py_API.rst#frank.radial_fitters.FrankFitter) class.\n", | |||
| "To do this we pass an object specifying how the geometry is determined to the [FrankFitter](../py_API.rst#frank.radial_fitters.FrankFitter) class. **The position angle and right ascension offset are defined east of north.**\n", | |||
There was a problem hiding this comment.
and right ascension offset are defined east of north this is not clear. see my previous comments
There was a problem hiding this comment.
Fixed in bbda275
mtazzari
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #154