HIP edits to XX-Response-Time-Windows-for-Witness-Rewarding.md #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added stakeholders section - please feel free to edit. Done some spelling and grammar corrections. And suggested edits to improve understanding of timings Alternate Proposal description reads to me that only a max of 5 will ever get rewarded Does it need an extra line saying how many will be selected if they respond in less than MAX_WITNESS_WAIT_WINDOWS_MS? Alternate example 2 Has 20 rewarded Does this mean you are defining default_max_witnesses_per_poc as 20? Or will all responding within MAX_WITNESS_WAIT_WINDOWS_MS get rewarded? In which case default_max_witnesses_per_poc needs setting at 256 or 64K
Alternate proposal reward all within the Window, The exemple are exemple with different number of witnessers. There is no default_max_witnesses_per_poc in the alterate proposal Let me check, if unclear, in the document |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added stakeholders section - please feel free to edit. Done some spelling and grammar corrections.
And suggested edits to improve understanding of timings
Alternate Proposal description reads to me that only a max of 5 will ever get rewarded Does it need an extra line saying how many will be selected if they respond in less than MAX_WITNESS_WAIT_WINDOWS_MS?
Alternate example 2
Has 20 rewarded
Does this mean you are defining default_max_witnesses_per_poc as 20? Or will all responding within MAX_WITNESS_WAIT_WINDOWS_MS get rewarded? In which case default_max_witnesses_per_poc needs setting at 256 or 64K