Merge pull request #4 from disler/codex/list-available-specs

Implement pocket_list_ids feature

Author: disler

src/mcp_server_pocket_pick/modules/data_types.py

@@ -64,4 +64,10 @@ class PocketItem(BaseModel):
     id: str
     created: datetime
     text: str
-    tags: List[str]
+    tags: List[str]
+
+
+class ListIdsCommand(BaseModel):
+    tags: List[str] = []
+    limit: int = 100
+    db_path: Path = DEFAULT_SQLITE_DATABASE_PATH

src/mcp_server_pocket_pick/modules/functionality/list_ids.py

@@ -0,0 +1,50 @@
+import sqlite3
+from typing import List
+import logging
+from ..data_types import ListIdsCommand
+from ..init_db import init_db, normalize_tags
+
+logger = logging.getLogger(__name__)
+
+def list_ids(command: ListIdsCommand) -> List[str]:
+    """List all item IDs in the database, optionally filtered by tags."""
+    normalized_tags = normalize_tags(command.tags) if command.tags else []
+
+    db = init_db(command.db_path)
+
+    try:
+        if normalized_tags:
+            placeholders = ', '.join(['?'] * len(normalized_tags))
+            query = f"""
+                SELECT id
+                FROM POCKET_PICK
+                WHERE id IN (
+                    SELECT id
+                    FROM POCKET_PICK
+                    WHERE (
+                        SELECT COUNT(*)
+                        FROM json_each(tags)
+                        WHERE json_each.value IN ({placeholders})
+                    ) = ?
+                )
+                ORDER BY created DESC
+                LIMIT ?
+            """
+            params = [*normalized_tags, len(normalized_tags), command.limit]
+        else:
+            query = """
+                SELECT id
+                FROM POCKET_PICK
+                ORDER BY created DESC
+                LIMIT ?
+            """
+            params = [command.limit]
+
+        cursor = db.execute(query, params)
+        results = [row[0] for row in cursor.fetchall()]
+        return results
+    except Exception as e:
+        logger.error(f"Error listing ids: {e}")
+        raise
+    finally:
+        db.close()

src/mcp_server_pocket_pick/server.py

@@ -20,6 +20,7 @@
     FindCommand, 
     ListCommand,
     ListTagsCommand,
+    ListIdsCommand,
     RemoveCommand,
     GetCommand,
     BackupCommand,
@@ -30,6 +31,7 @@
 from .modules.functionality.find import find
 from .modules.functionality.list import list_items
 from .modules.functionality.list_tags import list_tags
+from .modules.functionality.list_ids import list_ids
 from .modules.functionality.remove import remove
 from .modules.functionality.get import get
 from .modules.functionality.backup import backup
@@ -67,6 +69,11 @@ class PocketListTags(BaseModel):
     limit: int = 1000
     db: str = str(DEFAULT_SQLITE_DATABASE_PATH)
 
+class PocketListIds(BaseModel):
+    tags: List[str] = []
+    limit: int = 100
+    db: str = str(DEFAULT_SQLITE_DATABASE_PATH)
+
 class PocketRemove(BaseModel):
     id: str
     db: str = str(DEFAULT_SQLITE_DATABASE_PATH)
@@ -90,6 +97,7 @@ class PocketTools(str, Enum):
     FIND = "pocket_find"
     LIST = "pocket_list"
     LIST_TAGS = "pocket_list_tags"
+    LIST_IDS = "pocket_list_ids"
     REMOVE = "pocket_remove"
     GET = "pocket_get"
     BACKUP = "pocket_backup"
@@ -138,6 +146,11 @@ async def list_tools() -> list[Tool]:
                 description="List all tags in your pocket pick database with their counts",
                 inputSchema=PocketListTags.schema(),
             ),
+            Tool(
+                name=PocketTools.LIST_IDS,
+                description="List all item IDs in your pocket pick database, optionally filtered by tags",
+                inputSchema=PocketListIds.schema(),
+            ),
             Tool(
                 name=PocketTools.REMOVE,
                 description="Remove an item from your pocket pick database by ID",
@@ -285,6 +298,25 @@ async def call_tool(name: str, arguments: dict) -> list[TextContent]:
                     type="text",
                     text="\n".join(output)
                 )]
+
+            case PocketTools.LIST_IDS:
+                command = ListIdsCommand(
+                    tags=arguments.get("tags", []),
+                    limit=arguments.get("limit", 100),
+                    db_path=db_path
+                )
+                results = list_ids(command)
+
+                if not results:
+                    return [TextContent(
+                        type="text",
+                        text="No item IDs found."
+                    )]
+
+                return [TextContent(
+                    type="text",
+                    text="\n".join(results)
+                )]
 
             case PocketTools.REMOVE:
                 command = RemoveCommand(

src/mcp_server_pocket_pick/tests/functionality/test_list_ids.py

@@ -0,0 +1,86 @@
+import pytest
+import tempfile
+import os
+from pathlib import Path
+from ...modules.data_types import AddCommand, ListIdsCommand
+from ...modules.functionality.add import add
+from ...modules.functionality.list_ids import list_ids
+
+@pytest.fixture
+def temp_db_path():
+    fd, path = tempfile.mkstemp()
+    os.close(fd)
+    yield Path(path)
+    if os.path.exists(path):
+        os.unlink(path)
+
+@pytest.fixture
+def populated_db(temp_db_path):
+    items = [
+        {"id": "python-1", "text": "Python programming is fun", "tags": ["python", "programming", "fun"]},
+        {"id": "sql-1", "text": "SQL databases are powerful", "tags": ["sql", "database", "programming"]},
+        {"id": "testing-1", "text": "Testing code is important", "tags": ["testing", "code", "programming"]},
+        {"id": "regex-1", "text": "Regular expressions can be complex", "tags": ["regex", "programming", "advanced"]},
+        {"id": "learning-1", "text": "Learning new technologies is exciting", "tags": ["learning", "technology", "fun"]},
+    ]
+
+    for item in items:
+        command = AddCommand(
+            id=item["id"],
+            text=item["text"],
+            tags=item["tags"],
+            db_path=temp_db_path,
+        )
+        add(command)
+
+    return temp_db_path
+
+def test_list_ids_all(populated_db):
+    command = ListIdsCommand(
+        limit=10,
+        db_path=populated_db,
+    )
+
+    results = list_ids(command)
+
+    assert len(results) == 5
+    for expected in [
+        "python-1",
+        "sql-1",
+        "testing-1",
+        "regex-1",
+        "learning-1",
+    ]:
+        assert expected in results
+
+def test_list_ids_with_tags(populated_db):
+    command = ListIdsCommand(
+        tags=["programming"],
+        limit=10,
+        db_path=populated_db,
+    )
+
+    results = list_ids(command)
+
+    assert len(results) == 4
+    for expected in ["python-1", "sql-1", "testing-1", "regex-1"]:
+        assert expected in results
+
+def test_list_ids_limit(populated_db):
+    command = ListIdsCommand(
+        limit=2,
+        db_path=populated_db,
+    )
+
+    results = list_ids(command)
+
+    assert len(results) == 2
+
+def test_list_ids_empty_db(temp_db_path):
+    command = ListIdsCommand(
+        db_path=temp_db_path,
+    )
+
+    results = list_ids(command)
+
+    assert len(results) == 0