Fix AwsInstanceMetadata decoding #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daddykotex
reviewed
Oct 17, 2023
| | "AccessKeyId":"access-key", | ||
| | "SecretAccessKey":"secret-key", | ||
| | "Token":"token", | ||
| | "Expiration":"2023-03-03T17:56:46Z" |
There was a problem hiding this comment.
To be clear, the issue was that the schema did not define the timestamp format and the AwsInstanceMetadata uses date-time
correct?
There was a problem hiding this comment.
Yes, it's not well documented (at least I cannot find anything), but that's the behavior I'm observing.
Please see https://repost.aws/questions/QUgcf1EIOPS7GZNboeAiyO9Q/renewing-aws-credentials
There was a problem hiding this comment.
@msosnicki that's good. Could you inline a comment in the code with that link, and put a line with the changelog for the next release ?
kubukoz
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist (not all items are relevant to all PRs)