Update aws smithy version #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguel-vila
commented
Feb 26, 2024
| @@ -159,7 +159,6 @@ object ErrorMessageTraitValidatorSpec extends FunSuite { | |||
| .assemble() | |||
|
|
|||
| val expected = List( | |||
| noErrorTrait(union), | |||
There was a problem hiding this comment.
question: not sure what recent changes made this test fail because of this. Maybe these 2 Smithy validations have been separated and are not reported in parallel: traits validations and custom validations
edit: maybe it comes from this release: https://github.com/smithy-lang/smithy/releases/tag/1.44.0 , seems it might be this: smithy-lang/smithy#2098
There was a problem hiding this comment.
I think that makes sense 👍
Baccata
reviewed
Feb 27, 2024
| @@ -20,7 +20,9 @@ sealed abstract class EnumResult(_value: String, _name: String, _intValue: Int, | |||
| object EnumResult extends Enumeration[EnumResult] with ShapeTag.Companion[EnumResult] { | |||
| val id: ShapeId = ShapeId("smithy4s.example", "EnumResult") | |||
|
|
|||
| val hints: Hints = Hints.empty | |||
| val hints: Hints = Hints( | |||
There was a problem hiding this comment.
Let's prevent the rendering the Box trait altogether.
|
@miguel-vila, you need to re-run |
Baccata
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist (not all items are relevant to all PRs)