Change Blob equals semantics + fix tests #1526
Conversation
modules/core/src/smithy4s/Blob.scala
Outdated
| other.isInstanceOf[ByteBufferBlob] && | ||
| buf.compareTo(other.asInstanceOf[ByteBufferBlob].buf) == 0 | ||
| } | ||
| override def equals(other: Any): Boolean = |
There was a problem hiding this comment.
If the point of the PR is to allow Blob constructed from different manners to be equivalent to one another, then the equals method should be implemented at the level of the trait, not in each component.
Moreover, hashCode and equals should have the same coherence : if you're gonna treat differently structured Blobs are equivalent, then they need to have the same hashCode, therefore the hashCode implementation should also move to the trait.
You can have a look at fs2.Chunk, which the Blob datatype is largely inspired from.
There was a problem hiding this comment.
I was thinking about having equals in the trait, but never seen such definition and felt something might be off with it. The implementations are the same though, so it makes sense: if I define those two as top level methods, it will automatically eliminate the hashCode issue that I missed here.
PR Checklist (not all items are relevant to all PRs)
fixes #1521