Scala native support #289
Scala native support #289
Conversation
* Move a few constructs to the tests module * Depend directly on smithy-model in dynamicJVM * Surface a `loadModel` method in dynamicJVM
| } | ||
| } | ||
|
|
||
| object Http4sDynamicPizzaClientSpec extends smithy4s.tests.PizzaClientSpec { |
There was a problem hiding this comment.
moved this one to the http4s module.
| package smithy4s.dynamic | ||
| import smithy4s.tests._ | ||
|
|
||
| object DummyIO { |
There was a problem hiding this comment.
They call me Haxxor, destroyer of common-sense.
Seriously though, it was easier to do that than turn everything into a scala.util.Try
| case None => (map, Left(KeyNotFoundError(key))) | ||
| case Some(value) => (map - value, Right(())) | ||
| } | ||
| class KVStoreImpl(map: scala.collection.mutable.Map[String, String]) |
| Ref[IO] | ||
| .of(Map.empty[String, String]) | ||
| def kvStoreResource: IO[KVStore[IO]] = { | ||
| IO(scala.collection.mutable.Map.empty[String, String]) | ||
| .map { ref => |
There was a problem hiding this comment.
ref isn't an accurate name anymore more like mutableMap, go nameless
|
Just asking, would you accept a PR where I update the copyright everywhere, that we would merge to main (and eventually here) so that we reduce the noise in this PR ? |
|
I would certainly |
see #292 |
| val munitDeps = Def.setting { | ||
| if (virtualAxes.value.contains(VirtualAxis.native)) { | ||
| Seq( | ||
| Dependencies.MunitMilestone.core.value % Test, |
There was a problem hiding this comment.
what's the reason why we can't switch to the Milestone all together
| @@ -17,11 +17,11 @@ | |||
| package smithy4s | |||
|
|
|||
| import smithy.api.TimestampFormat | |||
| import smithy4s.Timestamp._ | |||
| import java.time._ | |||
| // import smithy4s.Timestamp._ | |||
There was a problem hiding this comment.
can we get rid of the comment here?
| "js" | ||
| } else "jvm" | ||
| } else if (projectId.endsWith(nativeSuffix)) { | ||
| projectId = projectId.dropRight(nativeSuffix.length) |
There was a problem hiding this comment.
gotta love the mutation :D
Adds Scala Native support (for Scala 3 only, to avoid the matrix increasing in size too much for something that is quite bleeding edge).
The supported modules are :
This PR also amends the dynamic module slightly to make it depend on the smithy-model library (on JVM only), facilitating the loading of dynamic services/schemas directly from a smithy Model. This makes tests a little bit easier to write and reduces the need for sharing some test-utilities across modules, which was leading to a cyclic module dependency that I was too lazy to solve via yet another indirection.
Additionally, because smithy4s-dynamic is built on native now, I had to remove the dependency to CE/weaver in its test. I wanted to keep the diff smallish, so I ended up making a dummy IO construct (totally not pure) to reduce the noise a little. When CE builds on native, we'll switch back.