httpResponseCode handling (server side) #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daddykotex
commented
Aug 18, 2022
| case OptionalResponseCode(f) => | ||
| OptionalResponseCode { s => f(get(s)) } | ||
| } | ||
| Contravariant[ResponseCodeExtractor].contramap(aExt)(get) |
There was a problem hiding this comment.
If this is a contravariant, there must be a type class for the Optional one, right?
This ensure that the member is excluded from the payload when serializing
daddykotex
changed the title
|
exciting |
…nse-code Conflicts: sampleSpecs/pizza.smithy
|
Let's create a 0.16 feature branch from main, change the target version for MiMA, and target that branch in this PR instead |
Baccata
reviewed
Aug 29, 2022
modules/core/src/smithy4s/http/internals/HttpResponseCodeSchemaVisitor.scala
Outdated
Show resolved
Hide resolved
|
will create a branch and target that new branch |
Baccata
reviewed
Aug 29, 2022
modules/http4s/src/smithy4s/http4s/internals/SmithyHttp4sServerEndpoint.scala
Outdated
Show resolved
Hide resolved
|
now pointing at |
Baccata
reviewed
Aug 29, 2022
modules/http4s/src/smithy4s/http4s/internals/SmithyHttp4sServerEndpoint.scala
Outdated
Show resolved
Hide resolved
|
I would say this is ready to go into |
Baccata
reviewed
Aug 30, 2022
| case _ => (_: A) => Metadata.empty | ||
| case StructureMetaEncode(f) => { (a: A) => | ||
| val struct = f(a) | ||
| val statusCode = statusCodeVisitor match { |
There was a problem hiding this comment.
same comment as before: you could extract this pattern matching outside of the scope where A is known and have a A => Option[Int].
Baccata
changed the title
Baccata
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take the value out of the output structure and use it as the status code of the http response.
Discard this member from the serialized json